This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-compress.git
The following commit(s) were added to refs/heads/master by this push:
new 2b6c2ebe Don't initialize an instance variable to its default value
2b6c2ebe is described below
commit 2b6c2ebe5fb26a5b3b4d7d3c750a123493d24e80
Author: Gary Gregory <[email protected]>
AuthorDate: Fri Oct 27 09:17:56 2023 -0400
Don't initialize an instance variable to its default value
---
.../compress/archivers/sevenz/AES256SHA256Decoder.java | 2 +-
.../compress/harmony/archive/internal/nls/Messages.java | 2 +-
.../org/apache/commons/compress/harmony/pack200/BandSet.java | 12 ++++++------
.../apache/commons/compress/harmony/pack200/ClassBands.java | 4 ++--
.../org/apache/commons/compress/harmony/pack200/IcBands.java | 2 +-
.../commons/compress/harmony/pack200/MetadataBandGroup.java | 2 +-
.../compress/archivers/zip/ScatterZipOutputStreamTest.java | 4 ++--
.../apache/commons/compress/archivers/zip/ZipFileTest.java | 2 +-
8 files changed, 15 insertions(+), 15 deletions(-)
diff --git
a/src/main/java/org/apache/commons/compress/archivers/sevenz/AES256SHA256Decoder.java
b/src/main/java/org/apache/commons/compress/archivers/sevenz/AES256SHA256Decoder.java
index 03f52983..582018f3 100644
---
a/src/main/java/org/apache/commons/compress/archivers/sevenz/AES256SHA256Decoder.java
+++
b/src/main/java/org/apache/commons/compress/archivers/sevenz/AES256SHA256Decoder.java
@@ -178,7 +178,7 @@ class AES256SHA256Decoder extends AbstractCoder {
// manual implementation for padding possible thanks to the size
of the file stored separately
private final int cipherBlockSize =
opts.getCipher().getBlockSize();
private final byte[] cipherBlockBuffer = new byte[cipherBlockSize];
- private int count = 0;
+ private int count;
@Override
public void close() throws IOException {
diff --git
a/src/main/java/org/apache/commons/compress/harmony/archive/internal/nls/Messages.java
b/src/main/java/org/apache/commons/compress/harmony/archive/internal/nls/Messages.java
index 93c81955..f747aa55 100644
---
a/src/main/java/org/apache/commons/compress/harmony/archive/internal/nls/Messages.java
+++
b/src/main/java/org/apache/commons/compress/harmony/archive/internal/nls/Messages.java
@@ -46,7 +46,7 @@ import java.util.ResourceBundle;
public class Messages {
// ResourceBundle holding the system messages.
- static private ResourceBundle bundle = null;
+ static private ResourceBundle bundle;
static {
// Attempt to load the messages.
diff --git
a/src/main/java/org/apache/commons/compress/harmony/pack200/BandSet.java
b/src/main/java/org/apache/commons/compress/harmony/pack200/BandSet.java
index 59303143..9d1ba67d 100644
--- a/src/main/java/org/apache/commons/compress/harmony/pack200/BandSet.java
+++ b/src/main/java/org/apache/commons/compress/harmony/pack200/BandSet.java
@@ -36,10 +36,10 @@ public abstract class BandSet {
public class BandAnalysisResults {
// The number of Codecs tried so far
- private int numCodecsTried = 0;
+ private int numCodecsTried;
// The number of bytes saved by using betterCodec instead of the
default codec
- private int saved = 0;
+ private int saved;
// Extra metadata to pass to the segment header (to be appended to the
// band_headers band)
@@ -65,11 +65,11 @@ public abstract class BandSet {
private int smallestDelta;
private int largestDelta;
- private int deltaIsAscending = 0;
- private int smallDeltaCount = 0;
+ private int deltaIsAscending;
+ private int smallDeltaCount;
- private double averageAbsoluteDelta = 0;
- private double averageAbsoluteValue = 0;
+ private double averageAbsoluteDelta;
+ private double averageAbsoluteValue;
private Map<Integer, Integer> distinctValues;
diff --git
a/src/main/java/org/apache/commons/compress/harmony/pack200/ClassBands.java
b/src/main/java/org/apache/commons/compress/harmony/pack200/ClassBands.java
index 0e95f1a8..2ed4c6bc 100644
--- a/src/main/java/org/apache/commons/compress/harmony/pack200/ClassBands.java
+++ b/src/main/java/org/apache/commons/compress/harmony/pack200/ClassBands.java
@@ -197,8 +197,8 @@ public class ClassBands extends BandSet {
private final Map<CPClass, Set<CPClass>> classReferencesInnerClass =
new HashMap<>();
private final boolean stripDebug;
- private int index = 0;
- private int numMethodArgs = 0;
+ private int index;
+ private int numMethodArgs;
private int[] class_InnerClasses_N;
private CPClass[] class_InnerClasses_RC;
private int[] class_InnerClasses_F;
diff --git
a/src/main/java/org/apache/commons/compress/harmony/pack200/IcBands.java
b/src/main/java/org/apache/commons/compress/harmony/pack200/IcBands.java
index 3e0707d8..0205f2fe 100644
--- a/src/main/java/org/apache/commons/compress/harmony/pack200/IcBands.java
+++ b/src/main/java/org/apache/commons/compress/harmony/pack200/IcBands.java
@@ -74,7 +74,7 @@ public class IcBands extends BandSet {
}
private final Set<IcTuple> innerClasses = new TreeSet<>();
private final CpBands cpBands;
- private int bit16Count = 0;
+ private int bit16Count;
private final Map<String, List<IcTuple>> outerToInner = new HashMap<>();
diff --git
a/src/main/java/org/apache/commons/compress/harmony/pack200/MetadataBandGroup.java
b/src/main/java/org/apache/commons/compress/harmony/pack200/MetadataBandGroup.java
index d0711136..fb1ac138 100644
---
a/src/main/java/org/apache/commons/compress/harmony/pack200/MetadataBandGroup.java
+++
b/src/main/java/org/apache/commons/compress/harmony/pack200/MetadataBandGroup.java
@@ -32,7 +32,7 @@ public class MetadataBandGroup extends BandSet {
public static final int CONTEXT_METHOD = 2;
private final String type;
- private int numBackwardsCalls = 0;
+ private int numBackwardsCalls;
public IntList param_NB = new IntList(); // TODO: Lazy instantiation?
public IntList anno_N = new IntList();
diff --git
a/src/test/java/org/apache/commons/compress/archivers/zip/ScatterZipOutputStreamTest.java
b/src/test/java/org/apache/commons/compress/archivers/zip/ScatterZipOutputStreamTest.java
index 07c76c2d..2b0f65f8 100644
---
a/src/test/java/org/apache/commons/compress/archivers/zip/ScatterZipOutputStreamTest.java
+++
b/src/test/java/org/apache/commons/compress/archivers/zip/ScatterZipOutputStreamTest.java
@@ -33,8 +33,8 @@ import org.junit.jupiter.api.Test;
public class ScatterZipOutputStreamTest {
- private File scatterFile = null;
- private File target = null;
+ private File scatterFile;
+ private File target;
@AfterEach
public void cleanup() {
diff --git
a/src/test/java/org/apache/commons/compress/archivers/zip/ZipFileTest.java
b/src/test/java/org/apache/commons/compress/archivers/zip/ZipFileTest.java
index db466e07..0a5e694e 100644
--- a/src/test/java/org/apache/commons/compress/archivers/zip/ZipFileTest.java
+++ b/src/test/java/org/apache/commons/compress/archivers/zip/ZipFileTest.java
@@ -83,7 +83,7 @@ public class ZipFileTest extends AbstractTestCase {
}
}
- private ZipFile zf = null;
+ private ZipFile zf;
private void assertAllReadMethods(final byte[] expected, final ZipFile
zipFile, final ZipArchiveEntry entry) throws IOException {
// simple IOUtil read
