This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-beanutils.git
The following commit(s) were added to refs/heads/master by this push:
new c94a5b72 Don't initialize an instance variable to its default value
c94a5b72 is described below
commit c94a5b72f68c682af0a5aa93be61534a7596581e
Author: Gary Gregory <[email protected]>
AuthorDate: Fri Oct 27 09:07:35 2023 -0400
Don't initialize an instance variable to its default value
---
.../org/apache/commons/beanutils2/BasicDynaBeanTestCase.java | 2 +-
.../apache/commons/beanutils2/BeanComparatorTestCase.java | 6 +++---
.../org/apache/commons/beanutils2/BeanUtilsBeanTestCase.java | 2 +-
.../org/apache/commons/beanutils2/BeanUtilsBenchCase.java | 12 ++++++------
.../org/apache/commons/beanutils2/BeanificationTestCase.java | 2 +-
.../org/apache/commons/beanutils2/DynaBeanUtilsTestCase.java | 4 ++--
.../apache/commons/beanutils2/DynaPropertyUtilsTestCase.java | 4 ++--
.../apache/commons/beanutils2/IndexedPropertyTestCase.java | 2 +-
.../org/apache/commons/beanutils2/LazyDynaBeanTestCase.java | 4 ++--
.../org/apache/commons/beanutils2/LazyDynaClassTestCase.java | 2 +-
.../org/apache/commons/beanutils2/LazyDynaMapTestCase.java | 2 +-
.../java/org/apache/commons/beanutils2/NestedTestBean.java | 2 +-
.../apache/commons/beanutils2/PropertyUtilsBenchCase.java | 12 ++++++------
.../org/apache/commons/beanutils2/PropertyUtilsTestCase.java | 10 +++++-----
src/test/java/org/apache/commons/beanutils2/TestBean.java | 12 ++++++------
.../org/apache/commons/beanutils2/bugs/Jira411TestCase.java | 2 +-
.../beanutils2/locale/LocaleBeanificationTestCase.java | 2 +-
.../apache/commons/beanutils2/sql/DynaResultSetTestCase.java | 2 +-
.../apache/commons/beanutils2/sql/DynaRowSetTestCase.java | 2 +-
.../org/apache/commons/beanutils2/sql/TestResultSet.java | 2 +-
20 files changed, 44 insertions(+), 44 deletions(-)
diff --git
a/src/test/java/org/apache/commons/beanutils2/BasicDynaBeanTestCase.java
b/src/test/java/org/apache/commons/beanutils2/BasicDynaBeanTestCase.java
index e88d96f7..ce0d07db 100644
--- a/src/test/java/org/apache/commons/beanutils2/BasicDynaBeanTestCase.java
+++ b/src/test/java/org/apache/commons/beanutils2/BasicDynaBeanTestCase.java
@@ -60,7 +60,7 @@ public class BasicDynaBeanTestCase extends TestCase {
/**
* The basic test bean for each test.
*/
- protected DynaBean bean = null;
+ protected DynaBean bean;
/**
* Constructs a new instance of this test case.
diff --git
a/src/test/java/org/apache/commons/beanutils2/BeanComparatorTestCase.java
b/src/test/java/org/apache/commons/beanutils2/BeanComparatorTestCase.java
index 93e3f948..d67b7f47 100644
--- a/src/test/java/org/apache/commons/beanutils2/BeanComparatorTestCase.java
+++ b/src/test/java/org/apache/commons/beanutils2/BeanComparatorTestCase.java
@@ -35,10 +35,10 @@ public class BeanComparatorTestCase extends TestCase {
/**
* The test beans for each test.
*/
- protected TestBean bean = null;
- protected AlphaBean alphaBean1 = null;
+ protected TestBean bean;
+ protected AlphaBean alphaBean1;
- protected AlphaBean alphaBean2 = null;
+ protected AlphaBean alphaBean2;
/**
* Constructs a new instance of this test case.
diff --git
a/src/test/java/org/apache/commons/beanutils2/BeanUtilsBeanTestCase.java
b/src/test/java/org/apache/commons/beanutils2/BeanUtilsBeanTestCase.java
index 3ca73340..c4bf08e3 100644
--- a/src/test/java/org/apache/commons/beanutils2/BeanUtilsBeanTestCase.java
+++ b/src/test/java/org/apache/commons/beanutils2/BeanUtilsBeanTestCase.java
@@ -90,7 +90,7 @@ public class BeanUtilsBeanTestCase extends TestCase {
/**
* The test bean for each test.
*/
- protected TestBean bean = null;
+ protected TestBean bean;
/**
* The set of properties that should be described.
diff --git
a/src/test/java/org/apache/commons/beanutils2/BeanUtilsBenchCase.java
b/src/test/java/org/apache/commons/beanutils2/BeanUtilsBenchCase.java
index 6cf346fb..69613649 100644
--- a/src/test/java/org/apache/commons/beanutils2/BeanUtilsBenchCase.java
+++ b/src/test/java/org/apache/commons/beanutils2/BeanUtilsBenchCase.java
@@ -42,20 +42,20 @@ public class BeanUtilsBenchCase extends TestCase {
private long counter = 100000;
// DynaClass for inDyna and outDyna
- private DynaClass dynaClass = null;
+ private DynaClass dynaClass;
// Input objects that have identical sets of properties and values.
- private BenchBean inBean = null;
- private DynaBean inDyna = null;
+ private BenchBean inBean;
+ private DynaBean inDyna;
private Map<String, Object> inMap = null; // Map of Objects requiring no
conversion
private Map<String, String> inStrs = null; // Map of Strings requiring
conversion
// Output objects that have identical sets of properties.
- private BenchBean outBean = null;
- private DynaBean outDyna = null;
+ private BenchBean outBean;
+ private DynaBean outDyna;
// BeanUtilsBean instance to be used
- private BeanUtilsBean bu = null;
+ private BeanUtilsBean bu;
/**
* Constructs a new instance of this test case.
diff --git
a/src/test/java/org/apache/commons/beanutils2/BeanificationTestCase.java
b/src/test/java/org/apache/commons/beanutils2/BeanificationTestCase.java
index 6f5012a5..447b6868 100644
--- a/src/test/java/org/apache/commons/beanutils2/BeanificationTestCase.java
+++ b/src/test/java/org/apache/commons/beanutils2/BeanificationTestCase.java
@@ -37,7 +37,7 @@ public class BeanificationTestCase extends TestCase {
class Signal {
private Exception e;
- private int signal = 0;
+ private int signal;
private BeanUtilsBean bean;
private PropertyUtilsBean propertyUtils;
private ConvertUtilsBean convertUtils;
diff --git
a/src/test/java/org/apache/commons/beanutils2/DynaBeanUtilsTestCase.java
b/src/test/java/org/apache/commons/beanutils2/DynaBeanUtilsTestCase.java
index b66380e5..63defffb 100644
--- a/src/test/java/org/apache/commons/beanutils2/DynaBeanUtilsTestCase.java
+++ b/src/test/java/org/apache/commons/beanutils2/DynaBeanUtilsTestCase.java
@@ -67,12 +67,12 @@ public class DynaBeanUtilsTestCase extends TestCase {
/**
* The basic test bean for each test.
*/
- protected DynaBean bean = null;
+ protected DynaBean bean;
/**
* The nested bean pointed at by the "nested" property.
*/
- protected TestBean nested = null;
+ protected TestBean nested;
/**
* The set of properties that should be described.
diff --git
a/src/test/java/org/apache/commons/beanutils2/DynaPropertyUtilsTestCase.java
b/src/test/java/org/apache/commons/beanutils2/DynaPropertyUtilsTestCase.java
index 9f097bde..5dc0a1ce 100644
--- a/src/test/java/org/apache/commons/beanutils2/DynaPropertyUtilsTestCase.java
+++ b/src/test/java/org/apache/commons/beanutils2/DynaPropertyUtilsTestCase.java
@@ -46,7 +46,7 @@ public class DynaPropertyUtilsTestCase extends TestCase {
/**
* The basic test bean for each test.
*/
- protected DynaBean bean = null;
+ protected DynaBean bean;
/**
* The set of properties that should be described.
@@ -59,7 +59,7 @@ public class DynaPropertyUtilsTestCase extends TestCase {
/**
* The nested bean pointed at by the "nested" property.
*/
- protected TestBean nested = null;
+ protected TestBean nested;
/**
* Constructs a new instance of this test case.
diff --git
a/src/test/java/org/apache/commons/beanutils2/IndexedPropertyTestCase.java
b/src/test/java/org/apache/commons/beanutils2/IndexedPropertyTestCase.java
index 4a1f4b30..160d8167 100644
--- a/src/test/java/org/apache/commons/beanutils2/IndexedPropertyTestCase.java
+++ b/src/test/java/org/apache/commons/beanutils2/IndexedPropertyTestCase.java
@@ -43,7 +43,7 @@ public class IndexedPropertyTestCase {
/**
* The test bean for each test.
*/
- private IndexedTestBean bean = null;
+ private IndexedTestBean bean;
private BeanUtilsBean beanUtilsBean;
private PropertyUtilsBean propertyUtilsBean;
private String[] testArray;
diff --git
a/src/test/java/org/apache/commons/beanutils2/LazyDynaBeanTestCase.java
b/src/test/java/org/apache/commons/beanutils2/LazyDynaBeanTestCase.java
index ae1b54a1..38bf84e5 100644
--- a/src/test/java/org/apache/commons/beanutils2/LazyDynaBeanTestCase.java
+++ b/src/test/java/org/apache/commons/beanutils2/LazyDynaBeanTestCase.java
@@ -46,8 +46,8 @@ public class LazyDynaBeanTestCase extends TestCase {
public static Test suite() {
return new TestSuite(LazyDynaBeanTestCase.class);
}
- protected LazyDynaBean bean = null;
- protected LazyDynaClass dynaClass = null;
+ protected LazyDynaBean bean;
+ protected LazyDynaClass dynaClass;
protected String testProperty = "myProperty";
protected String testPropertyA = "myProperty-A";
protected String testPropertyB = "myProperty-B";
diff --git
a/src/test/java/org/apache/commons/beanutils2/LazyDynaClassTestCase.java
b/src/test/java/org/apache/commons/beanutils2/LazyDynaClassTestCase.java
index ccd44e23..8a44f2ad 100644
--- a/src/test/java/org/apache/commons/beanutils2/LazyDynaClassTestCase.java
+++ b/src/test/java/org/apache/commons/beanutils2/LazyDynaClassTestCase.java
@@ -41,7 +41,7 @@ public class LazyDynaClassTestCase extends TestCase {
return new TestSuite(LazyDynaClassTestCase.class);
}
- protected LazyDynaClass dynaClass = null;
+ protected LazyDynaClass dynaClass;
protected String testProperty = "myProperty";
diff --git
a/src/test/java/org/apache/commons/beanutils2/LazyDynaMapTestCase.java
b/src/test/java/org/apache/commons/beanutils2/LazyDynaMapTestCase.java
index b669280c..ff90e917 100644
--- a/src/test/java/org/apache/commons/beanutils2/LazyDynaMapTestCase.java
+++ b/src/test/java/org/apache/commons/beanutils2/LazyDynaMapTestCase.java
@@ -48,7 +48,7 @@ public class LazyDynaMapTestCase extends TestCase {
public static Test suite() {
return new TestSuite(LazyDynaMapTestCase.class);
}
- protected LazyDynaMap dynaMap = null;
+ protected LazyDynaMap dynaMap;
protected String testProperty = "myProperty";
protected String testPropertyA = "myProperty-A";
protected String testPropertyB = "myProperty-B";
diff --git a/src/test/java/org/apache/commons/beanutils2/NestedTestBean.java
b/src/test/java/org/apache/commons/beanutils2/NestedTestBean.java
index f5fbffef..04cf0c08 100644
--- a/src/test/java/org/apache/commons/beanutils2/NestedTestBean.java
+++ b/src/test/java/org/apache/commons/beanutils2/NestedTestBean.java
@@ -28,7 +28,7 @@ public class NestedTestBean {
private String testString = "NOT SET";
- private boolean testBoolean = false;
+ private boolean testBoolean;
private NestedTestBean[] indexedBeans;
diff --git
a/src/test/java/org/apache/commons/beanutils2/PropertyUtilsBenchCase.java
b/src/test/java/org/apache/commons/beanutils2/PropertyUtilsBenchCase.java
index 8c0b7fb2..58c5ba83 100644
--- a/src/test/java/org/apache/commons/beanutils2/PropertyUtilsBenchCase.java
+++ b/src/test/java/org/apache/commons/beanutils2/PropertyUtilsBenchCase.java
@@ -44,19 +44,19 @@ public class PropertyUtilsBenchCase extends TestCase {
private long counter = 100000;
// DynaClass for inDyna and outDyna
- private DynaClass dynaClass = null;
+ private DynaClass dynaClass;
// Input objects that have identical sets of properties and values.
- private BenchBean inBean = null;
- private DynaBean inDyna = null;
+ private BenchBean inBean;
+ private DynaBean inDyna;
private Map<String, Object> inMap = null;
// Output objects that have identical sets of properties.
- private BenchBean outBean = null;
- private DynaBean outDyna = null;
+ private BenchBean outBean;
+ private DynaBean outDyna;
// PropertyUtilsBean instance to be used
- private PropertyUtilsBean pu = null;
+ private PropertyUtilsBean pu;
/**
* Constructs a new instance of this test case.
diff --git
a/src/test/java/org/apache/commons/beanutils2/PropertyUtilsTestCase.java
b/src/test/java/org/apache/commons/beanutils2/PropertyUtilsTestCase.java
index 60b71153..64b5f41c 100644
--- a/src/test/java/org/apache/commons/beanutils2/PropertyUtilsTestCase.java
+++ b/src/test/java/org/apache/commons/beanutils2/PropertyUtilsTestCase.java
@@ -118,27 +118,27 @@ public class PropertyUtilsTestCase extends TestCase {
/**
* The basic test bean for each test.
*/
- protected TestBean bean = null;
+ protected TestBean bean;
/**
* The "package private subclass" test bean for each test.
*/
- protected TestBeanPackageSubclass beanPackageSubclass = null;
+ protected TestBeanPackageSubclass beanPackageSubclass;
/**
* The test bean for private access tests.
*/
- protected PrivateDirect beanPrivate = null;
+ protected PrivateDirect beanPrivate;
/**
* The test bean for private access tests of subclasses.
*/
- protected PrivateDirect beanPrivateSubclass = null;
+ protected PrivateDirect beanPrivateSubclass;
/**
* The "public subclass" test bean for each test.
*/
- protected TestBeanPublicSubclass beanPublicSubclass = null;
+ protected TestBeanPublicSubclass beanPublicSubclass;
/**
* The set of properties that should be described.
diff --git a/src/test/java/org/apache/commons/beanutils2/TestBean.java
b/src/test/java/org/apache/commons/beanutils2/TestBean.java
index 1a3e07d0..1b4e3f6d 100644
--- a/src/test/java/org/apache/commons/beanutils2/TestBean.java
+++ b/src/test/java/org/apache/commons/beanutils2/TestBean.java
@@ -171,24 +171,24 @@ public class TestBean implements Serializable {
/**
* A nested reference to another test bean (populated as needed).
*/
- private TestBean nested = null;
+ private TestBean nested;
/**
* Another nested reference to another test bean,
*/
- private TestBean anotherNested = null;
+ private TestBean anotherNested;
/**
* Another nested reference to another test bean,
*/
- private DynaBean nestedDynaBean = null;
+ private DynaBean nestedDynaBean;
- private MappedTestBean mappedNested = null;
+ private MappedTestBean mappedNested;
/**
* A String property with an initial value of null.
*/
- private String nullProperty = null;
+ private String nullProperty;
/**
* A read-only String property.
@@ -228,7 +228,7 @@ public class TestBean implements Serializable {
* described in the JavaBeans Specification, this will be considered a
read-only boolean property, using isInvalidBoolean() as the getter.
* </p>
*/
- private boolean invalidBoolean = false;
+ private boolean invalidBoolean;
public TestBean() {
listIndexed.add("String 0");
diff --git
a/src/test/java/org/apache/commons/beanutils2/bugs/Jira411TestCase.java
b/src/test/java/org/apache/commons/beanutils2/bugs/Jira411TestCase.java
index 1db07e30..a3041dfc 100644
--- a/src/test/java/org/apache/commons/beanutils2/bugs/Jira411TestCase.java
+++ b/src/test/java/org/apache/commons/beanutils2/bugs/Jira411TestCase.java
@@ -29,7 +29,7 @@ public class Jira411TestCase extends TestCase {
public class DummyBean {
- private String imgLink = null;
+ private String imgLink;
public String getImgLink() {
return imgLink;
diff --git
a/src/test/java/org/apache/commons/beanutils2/locale/LocaleBeanificationTestCase.java
b/src/test/java/org/apache/commons/beanutils2/locale/LocaleBeanificationTestCase.java
index b1be6c4e..88c8efea 100644
---
a/src/test/java/org/apache/commons/beanutils2/locale/LocaleBeanificationTestCase.java
+++
b/src/test/java/org/apache/commons/beanutils2/locale/LocaleBeanificationTestCase.java
@@ -49,7 +49,7 @@ public class LocaleBeanificationTestCase {
class Signal {
private Exception e;
- private int signal = 0;
+ private int signal;
private LocaleBeanUtilsBean bean;
private LocaleConvertUtilsBean convertUtils;
private Object marker;
diff --git
a/src/test/java/org/apache/commons/beanutils2/sql/DynaResultSetTestCase.java
b/src/test/java/org/apache/commons/beanutils2/sql/DynaResultSetTestCase.java
index dc4da79c..ac30b699 100644
--- a/src/test/java/org/apache/commons/beanutils2/sql/DynaResultSetTestCase.java
+++ b/src/test/java/org/apache/commons/beanutils2/sql/DynaResultSetTestCase.java
@@ -46,7 +46,7 @@ public class DynaResultSetTestCase extends TestCase {
/**
* The mock result set DynaClass to be tested.
*/
- protected ResultSetDynaClass dynaClass = null;
+ protected ResultSetDynaClass dynaClass;
/**
* Names of the columns for this test. Must match the order they are
defined in {@link TestResultSetMetaData}, and must be all lower case.
diff --git
a/src/test/java/org/apache/commons/beanutils2/sql/DynaRowSetTestCase.java
b/src/test/java/org/apache/commons/beanutils2/sql/DynaRowSetTestCase.java
index c10a3bdc..c414668f 100644
--- a/src/test/java/org/apache/commons/beanutils2/sql/DynaRowSetTestCase.java
+++ b/src/test/java/org/apache/commons/beanutils2/sql/DynaRowSetTestCase.java
@@ -113,7 +113,7 @@ public class DynaRowSetTestCase extends TestCase {
/**
* The mock result set DynaClass to be tested.
*/
- protected RowSetDynaClass dynaClass = null;
+ protected RowSetDynaClass dynaClass;
/**
* Names of the columns for this test. Must match the order they are
defined in {@link TestResultSetMetaData}, and must be all lower case.
diff --git a/src/test/java/org/apache/commons/beanutils2/sql/TestResultSet.java
b/src/test/java/org/apache/commons/beanutils2/sql/TestResultSet.java
index b2ae3c7e..af575e01 100644
--- a/src/test/java/org/apache/commons/beanutils2/sql/TestResultSet.java
+++ b/src/test/java/org/apache/commons/beanutils2/sql/TestResultSet.java
@@ -72,7 +72,7 @@ public class TestResultSet implements InvocationHandler {
/**
* Current row number (0 means "before the first one").
*/
- protected int row = 0;
+ protected int row;
/**
* The constant (per run) value used to initialize date/time/timestamp.