This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-beanutils.git
The following commit(s) were added to refs/heads/master by this push:
new a12f1ee1 Don't initialize an instance variable to its default value
a12f1ee1 is described below
commit a12f1ee10f2b588a414dfbbac6f451812a951d08
Author: Gary Gregory <[email protected]>
AuthorDate: Fri Oct 27 09:29:40 2023 -0400
Don't initialize an instance variable to its default value
---
src/conf/checkstyle.xml | 1 +
.../java/org/apache/commons/beanutils2/BeanUtilsBenchCase.java | 4 ++--
.../org/apache/commons/beanutils2/PropertyUtilsBenchCase.java | 2 +-
src/test/java/org/apache/commons/beanutils2/TestBean.java | 10 +++++-----
.../beanutils2/converters/BigDecimalConverterTestCase.java | 2 +-
.../beanutils2/converters/BigIntegerConverterTestCase.java | 2 +-
.../commons/beanutils2/converters/ByteConverterTestCase.java | 2 +-
.../commons/beanutils2/converters/DoubleConverterTestCase.java | 2 +-
.../commons/beanutils2/converters/FloatConverterTestCase.java | 2 +-
.../commons/beanutils2/converters/LongConverterTestCase.java | 2 +-
.../beanutils2/converters/OffsetTimeConverterTestCase.java | 2 +-
.../commons/beanutils2/converters/PathConverterTestCase.java | 2 +-
.../commons/beanutils2/converters/PeriodConverterTestCase.java | 2 +-
.../commons/beanutils2/converters/URIConverterTestCase.java | 2 +-
.../commons/beanutils2/converters/UUIDConverterTestCase.java | 2 +-
.../commons/beanutils2/converters/YearConverterTestCase.java | 2 +-
.../beanutils2/converters/ZoneOffsetConverterTestCase.java | 2 +-
.../beanutils2/memoryleaktests/pojotests/SomeMappedPojo.java | 2 +-
18 files changed, 23 insertions(+), 22 deletions(-)
diff --git a/src/conf/checkstyle.xml b/src/conf/checkstyle.xml
index ad865d61..35c330e6 100644
--- a/src/conf/checkstyle.xml
+++ b/src/conf/checkstyle.xml
@@ -38,6 +38,7 @@ limitations under the License.
<property name="max" value="160"/>
</module>
<module name="TreeWalker">
+ <module name="ExplicitInitializationCheck" />
<module name="AvoidStarImport"/>
<module name="RedundantImport"/>
<module name="UnusedImports"/>
diff --git
a/src/test/java/org/apache/commons/beanutils2/BeanUtilsBenchCase.java
b/src/test/java/org/apache/commons/beanutils2/BeanUtilsBenchCase.java
index 69613649..0ff0dc04 100644
--- a/src/test/java/org/apache/commons/beanutils2/BeanUtilsBenchCase.java
+++ b/src/test/java/org/apache/commons/beanutils2/BeanUtilsBenchCase.java
@@ -47,8 +47,8 @@ public class BeanUtilsBenchCase extends TestCase {
// Input objects that have identical sets of properties and values.
private BenchBean inBean;
private DynaBean inDyna;
- private Map<String, Object> inMap = null; // Map of Objects requiring no
conversion
- private Map<String, String> inStrs = null; // Map of Strings requiring
conversion
+ private Map<String, Object> inMap; // Map of Objects requiring no
conversion
+ private Map<String, String> inStrs; // Map of Strings requiring conversion
// Output objects that have identical sets of properties.
private BenchBean outBean;
diff --git
a/src/test/java/org/apache/commons/beanutils2/PropertyUtilsBenchCase.java
b/src/test/java/org/apache/commons/beanutils2/PropertyUtilsBenchCase.java
index 58c5ba83..3432958f 100644
--- a/src/test/java/org/apache/commons/beanutils2/PropertyUtilsBenchCase.java
+++ b/src/test/java/org/apache/commons/beanutils2/PropertyUtilsBenchCase.java
@@ -49,7 +49,7 @@ public class PropertyUtilsBenchCase extends TestCase {
// Input objects that have identical sets of properties and values.
private BenchBean inBean;
private DynaBean inDyna;
- private Map<String, Object> inMap = null;
+ private Map<String, Object> inMap;
// Output objects that have identical sets of properties.
private BenchBean outBean;
diff --git a/src/test/java/org/apache/commons/beanutils2/TestBean.java
b/src/test/java/org/apache/commons/beanutils2/TestBean.java
index 1b4e3f6d..3c5f319a 100644
--- a/src/test/java/org/apache/commons/beanutils2/TestBean.java
+++ b/src/test/java/org/apache/commons/beanutils2/TestBean.java
@@ -45,7 +45,7 @@ public class TestBean implements Serializable {
/**
* A static variable that is accessed and updated via static methods for
MethodUtils testing.
*/
- private static int counter = 0;
+ private static int counter;
/**
* Gets the current value of the counter.
@@ -151,22 +151,22 @@ public class TestBean implements Serializable {
/**
* A mapped property with only a getter and setter for a Map.
*/
- private Map<String, Object> mapProperty = null;
+ private Map<String, Object> mapProperty;
/**
* A mapped property that has String keys and Object values.
*/
- private HashMap<String, Object> mappedObjects = null;
+ private HashMap<String, Object> mappedObjects;
/**
* A mapped property that has String keys and String values.
*/
- private HashMap<String, String> mappedProperty = null;
+ private HashMap<String, String> mappedProperty;
/**
* A mapped property that has String keys and int values.
*/
- private HashMap<String, Integer> mappedIntProperty = null;
+ private HashMap<String, Integer> mappedIntProperty;
/**
* A nested reference to another test bean (populated as needed).
diff --git
a/src/test/java/org/apache/commons/beanutils2/converters/BigDecimalConverterTestCase.java
b/src/test/java/org/apache/commons/beanutils2/converters/BigDecimalConverterTestCase.java
index 1db3d169..94318f65 100644
---
a/src/test/java/org/apache/commons/beanutils2/converters/BigDecimalConverterTestCase.java
+++
b/src/test/java/org/apache/commons/beanutils2/converters/BigDecimalConverterTestCase.java
@@ -43,7 +43,7 @@ public class BigDecimalConverterTestCase extends
AbstractNumberConverterTest<Big
return new TestSuite(BigDecimalConverterTestCase.class);
}
- private Converter<BigDecimal> converter = null;
+ private Converter<BigDecimal> converter;
public BigDecimalConverterTestCase(final String name) {
super(name);
diff --git
a/src/test/java/org/apache/commons/beanutils2/converters/BigIntegerConverterTestCase.java
b/src/test/java/org/apache/commons/beanutils2/converters/BigIntegerConverterTestCase.java
index d911a274..9af3d25d 100644
---
a/src/test/java/org/apache/commons/beanutils2/converters/BigIntegerConverterTestCase.java
+++
b/src/test/java/org/apache/commons/beanutils2/converters/BigIntegerConverterTestCase.java
@@ -32,7 +32,7 @@ public class BigIntegerConverterTestCase extends
AbstractNumberConverterTest<Big
return new TestSuite(BigIntegerConverterTestCase.class);
}
- private Converter<BigInteger> converter = null;
+ private Converter<BigInteger> converter;
public BigIntegerConverterTestCase(final String name) {
super(name);
diff --git
a/src/test/java/org/apache/commons/beanutils2/converters/ByteConverterTestCase.java
b/src/test/java/org/apache/commons/beanutils2/converters/ByteConverterTestCase.java
index 1544f53b..90753c50 100644
---
a/src/test/java/org/apache/commons/beanutils2/converters/ByteConverterTestCase.java
+++
b/src/test/java/org/apache/commons/beanutils2/converters/ByteConverterTestCase.java
@@ -30,7 +30,7 @@ public class ByteConverterTestCase extends
AbstractNumberConverterTest<Byte> {
return new TestSuite(ByteConverterTestCase.class);
}
- private Converter<Byte> converter = null;
+ private Converter<Byte> converter;
public ByteConverterTestCase(final String name) {
super(name);
diff --git
a/src/test/java/org/apache/commons/beanutils2/converters/DoubleConverterTestCase.java
b/src/test/java/org/apache/commons/beanutils2/converters/DoubleConverterTestCase.java
index 717f44cb..f098546a 100644
---
a/src/test/java/org/apache/commons/beanutils2/converters/DoubleConverterTestCase.java
+++
b/src/test/java/org/apache/commons/beanutils2/converters/DoubleConverterTestCase.java
@@ -30,7 +30,7 @@ public class DoubleConverterTestCase extends
AbstractNumberConverterTest<Double>
return new TestSuite(DoubleConverterTestCase.class);
}
- private Converter<Double> converter = null;
+ private Converter<Double> converter;
public DoubleConverterTestCase(final String name) {
super(name);
diff --git
a/src/test/java/org/apache/commons/beanutils2/converters/FloatConverterTestCase.java
b/src/test/java/org/apache/commons/beanutils2/converters/FloatConverterTestCase.java
index be808ce1..93806a35 100644
---
a/src/test/java/org/apache/commons/beanutils2/converters/FloatConverterTestCase.java
+++
b/src/test/java/org/apache/commons/beanutils2/converters/FloatConverterTestCase.java
@@ -30,7 +30,7 @@ public class FloatConverterTestCase extends
AbstractNumberConverterTest<Float> {
return new TestSuite(FloatConverterTestCase.class);
}
- private Converter<Float> converter = null;
+ private Converter<Float> converter;
public FloatConverterTestCase(final String name) {
super(name);
diff --git
a/src/test/java/org/apache/commons/beanutils2/converters/LongConverterTestCase.java
b/src/test/java/org/apache/commons/beanutils2/converters/LongConverterTestCase.java
index d28c9a15..44322b46 100644
---
a/src/test/java/org/apache/commons/beanutils2/converters/LongConverterTestCase.java
+++
b/src/test/java/org/apache/commons/beanutils2/converters/LongConverterTestCase.java
@@ -30,7 +30,7 @@ public class LongConverterTestCase extends
AbstractNumberConverterTest<Long> {
return new TestSuite(LongConverterTestCase.class);
}
- private Converter<Long> converter = null;
+ private Converter<Long> converter;
public LongConverterTestCase(final String name) {
super(name);
diff --git
a/src/test/java/org/apache/commons/beanutils2/converters/OffsetTimeConverterTestCase.java
b/src/test/java/org/apache/commons/beanutils2/converters/OffsetTimeConverterTestCase.java
index 4ce34be8..1a8e1e9c 100644
---
a/src/test/java/org/apache/commons/beanutils2/converters/OffsetTimeConverterTestCase.java
+++
b/src/test/java/org/apache/commons/beanutils2/converters/OffsetTimeConverterTestCase.java
@@ -34,7 +34,7 @@ public class OffsetTimeConverterTestCase extends TestCase {
return new TestSuite(OffsetTimeConverterTestCase.class);
}
- private Converter<OffsetTime> converter = null;
+ private Converter<OffsetTime> converter;
public OffsetTimeConverterTestCase(final String name) {
super(name);
diff --git
a/src/test/java/org/apache/commons/beanutils2/converters/PathConverterTestCase.java
b/src/test/java/org/apache/commons/beanutils2/converters/PathConverterTestCase.java
index 1f6b5b58..124f8026 100644
---
a/src/test/java/org/apache/commons/beanutils2/converters/PathConverterTestCase.java
+++
b/src/test/java/org/apache/commons/beanutils2/converters/PathConverterTestCase.java
@@ -37,7 +37,7 @@ public class PathConverterTestCase extends TestCase {
return new TestSuite(PathConverterTestCase.class);
}
- private Converter<Path> converter = null;
+ private Converter<Path> converter;
public PathConverterTestCase(final String name) {
super(name);
diff --git
a/src/test/java/org/apache/commons/beanutils2/converters/PeriodConverterTestCase.java
b/src/test/java/org/apache/commons/beanutils2/converters/PeriodConverterTestCase.java
index eb73e937..5616adfd 100644
---
a/src/test/java/org/apache/commons/beanutils2/converters/PeriodConverterTestCase.java
+++
b/src/test/java/org/apache/commons/beanutils2/converters/PeriodConverterTestCase.java
@@ -35,7 +35,7 @@ public class PeriodConverterTestCase extends TestCase {
return new TestSuite(PeriodConverterTestCase.class);
}
- private Converter<Period> converter = null;
+ private Converter<Period> converter;
public PeriodConverterTestCase(final String name) {
super(name);
diff --git
a/src/test/java/org/apache/commons/beanutils2/converters/URIConverterTestCase.java
b/src/test/java/org/apache/commons/beanutils2/converters/URIConverterTestCase.java
index 4cd06266..13956001 100644
---
a/src/test/java/org/apache/commons/beanutils2/converters/URIConverterTestCase.java
+++
b/src/test/java/org/apache/commons/beanutils2/converters/URIConverterTestCase.java
@@ -35,7 +35,7 @@ public class URIConverterTestCase extends TestCase {
return new TestSuite(URIConverterTestCase.class);
}
- private Converter<URI> converter = null;
+ private Converter<URI> converter;
public URIConverterTestCase(final String name) {
super(name);
diff --git
a/src/test/java/org/apache/commons/beanutils2/converters/UUIDConverterTestCase.java
b/src/test/java/org/apache/commons/beanutils2/converters/UUIDConverterTestCase.java
index 13b872ba..5a6b73cb 100644
---
a/src/test/java/org/apache/commons/beanutils2/converters/UUIDConverterTestCase.java
+++
b/src/test/java/org/apache/commons/beanutils2/converters/UUIDConverterTestCase.java
@@ -35,7 +35,7 @@ public class UUIDConverterTestCase extends TestCase {
return new TestSuite(UUIDConverterTestCase.class);
}
- private Converter<UUID> converter = null;
+ private Converter<UUID> converter;
public UUIDConverterTestCase(final String name) {
super(name);
diff --git
a/src/test/java/org/apache/commons/beanutils2/converters/YearConverterTestCase.java
b/src/test/java/org/apache/commons/beanutils2/converters/YearConverterTestCase.java
index 7d275f8e..2fd5bc14 100644
---
a/src/test/java/org/apache/commons/beanutils2/converters/YearConverterTestCase.java
+++
b/src/test/java/org/apache/commons/beanutils2/converters/YearConverterTestCase.java
@@ -34,7 +34,7 @@ public class YearConverterTestCase extends TestCase {
return new TestSuite(YearConverterTestCase.class);
}
- private Converter<Year> converter = null;
+ private Converter<Year> converter;
public YearConverterTestCase(final String name) {
super(name);
diff --git
a/src/test/java/org/apache/commons/beanutils2/converters/ZoneOffsetConverterTestCase.java
b/src/test/java/org/apache/commons/beanutils2/converters/ZoneOffsetConverterTestCase.java
index 74faacd2..e162fa83 100644
---
a/src/test/java/org/apache/commons/beanutils2/converters/ZoneOffsetConverterTestCase.java
+++
b/src/test/java/org/apache/commons/beanutils2/converters/ZoneOffsetConverterTestCase.java
@@ -35,7 +35,7 @@ public class ZoneOffsetConverterTestCase extends TestCase {
return new TestSuite(ZoneOffsetConverterTestCase.class);
}
- private Converter<ZoneOffset> converter = null;
+ private Converter<ZoneOffset> converter;
public ZoneOffsetConverterTestCase(final String name) {
super(name);
diff --git
a/src/test/java/org/apache/commons/beanutils2/memoryleaktests/pojotests/SomeMappedPojo.java
b/src/test/java/org/apache/commons/beanutils2/memoryleaktests/pojotests/SomeMappedPojo.java
index 9fe08bfe..d96c8def 100644
---
a/src/test/java/org/apache/commons/beanutils2/memoryleaktests/pojotests/SomeMappedPojo.java
+++
b/src/test/java/org/apache/commons/beanutils2/memoryleaktests/pojotests/SomeMappedPojo.java
@@ -24,7 +24,7 @@ import java.util.HashMap;
*/
public class SomeMappedPojo {
- private HashMap<String, String> mappedProperty = null;
+ private HashMap<String, String> mappedProperty;
public String getMappedProperty(final String key) {
// Create the map the very first time
