This is an automated email from the ASF dual-hosted git repository. ggregory pushed a commit to branch 1.X in repository https://gitbox.apache.org/repos/asf/commons-beanutils.git
commit dd783f9f3c92c1d98a09ff7dab35ff258938a296 Author: Gary D. Gregory <[email protected]> AuthorDate: Wed Dec 25 18:25:55 2024 -0500 Don't initialize instance variables to their default values --- .../java/org/apache/commons/beanutils/ContextClassLoaderLocal.java | 2 +- src/main/java/org/apache/commons/beanutils/LazyDynaClass.java | 2 +- src/main/java/org/apache/commons/beanutils/LazyDynaMap.java | 2 +- src/main/java/org/apache/commons/beanutils/ResultSetIterator.java | 4 ++-- .../org/apache/commons/beanutils/converters/AbstractConverter.java | 2 +- .../java/org/apache/commons/beanutils/locale/BaseLocaleConverter.java | 4 ++-- .../org/apache/commons/beanutils/locale/LocaleConvertUtilsBean.java | 2 +- src/test/java/org/apache/commons/beanutils/NestedTestBean.java | 2 +- src/test/java/org/apache/commons/beanutils/TestBean.java | 2 +- 9 files changed, 11 insertions(+), 11 deletions(-) diff --git a/src/main/java/org/apache/commons/beanutils/ContextClassLoaderLocal.java b/src/main/java/org/apache/commons/beanutils/ContextClassLoaderLocal.java index a1447b98..3b4e0f0a 100644 --- a/src/main/java/org/apache/commons/beanutils/ContextClassLoaderLocal.java +++ b/src/main/java/org/apache/commons/beanutils/ContextClassLoaderLocal.java @@ -102,7 +102,7 @@ import java.util.WeakHashMap; */ public class ContextClassLoaderLocal<T> { private final Map<ClassLoader, T> valueByClassLoader = new WeakHashMap<>(); - private boolean globalValueInitialized = false; + private boolean globalValueInitialized; private T globalValue; /** diff --git a/src/main/java/org/apache/commons/beanutils/LazyDynaClass.java b/src/main/java/org/apache/commons/beanutils/LazyDynaClass.java index b2d1ff25..34552ef9 100644 --- a/src/main/java/org/apache/commons/beanutils/LazyDynaClass.java +++ b/src/main/java/org/apache/commons/beanutils/LazyDynaClass.java @@ -56,7 +56,7 @@ public class LazyDynaClass extends BasicDynaClass implements MutableDynaClass { * * <p>Default is <code>false</code>. */ - protected boolean returnNull = false; + protected boolean returnNull; /** * Construct a new LazyDynaClass with default parameters. diff --git a/src/main/java/org/apache/commons/beanutils/LazyDynaMap.java b/src/main/java/org/apache/commons/beanutils/LazyDynaMap.java index 79bd3be2..5c24e153 100644 --- a/src/main/java/org/apache/commons/beanutils/LazyDynaMap.java +++ b/src/main/java/org/apache/commons/beanutils/LazyDynaMap.java @@ -65,7 +65,7 @@ public class LazyDynaMap extends LazyDynaBean implements MutableDynaClass { * * <p>Default is <code>false</code>. */ - protected boolean returnNull = false; + protected boolean returnNull; /** * Constructs a new instance. diff --git a/src/main/java/org/apache/commons/beanutils/ResultSetIterator.java b/src/main/java/org/apache/commons/beanutils/ResultSetIterator.java index 5410dbed..21f7d981 100644 --- a/src/main/java/org/apache/commons/beanutils/ResultSetIterator.java +++ b/src/main/java/org/apache/commons/beanutils/ResultSetIterator.java @@ -34,7 +34,7 @@ public class ResultSetIterator implements DynaBean, Iterator<DynaBean> { * <p>Flag indicating whether the result set is currently positioned at a * row for which we have not yet returned an element in the iteration.</p> */ - protected boolean current = false; + protected boolean current; /** * <p>The {@link ResultSetDynaClass} we are associated with.</p> @@ -45,7 +45,7 @@ public class ResultSetIterator implements DynaBean, Iterator<DynaBean> { * <p>Flag indicating whether the result set has indicated that there are * no further rows.</p> */ - protected boolean eof = false; + protected boolean eof; /** * <p>Construct an <code>Iterator</code> for the result set being wrapped diff --git a/src/main/java/org/apache/commons/beanutils/converters/AbstractConverter.java b/src/main/java/org/apache/commons/beanutils/converters/AbstractConverter.java index 726076ed..3c875b8a 100644 --- a/src/main/java/org/apache/commons/beanutils/converters/AbstractConverter.java +++ b/src/main/java/org/apache/commons/beanutils/converters/AbstractConverter.java @@ -72,7 +72,7 @@ public abstract class AbstractConverter implements Converter { /** * Should we return the default value on conversion errors? */ - private boolean useDefault = false; + private boolean useDefault; /** * The default value specified to our Constructor, if any. diff --git a/src/main/java/org/apache/commons/beanutils/locale/BaseLocaleConverter.java b/src/main/java/org/apache/commons/beanutils/locale/BaseLocaleConverter.java index dd82f717..fa9bcf0a 100644 --- a/src/main/java/org/apache/commons/beanutils/locale/BaseLocaleConverter.java +++ b/src/main/java/org/apache/commons/beanutils/locale/BaseLocaleConverter.java @@ -75,7 +75,7 @@ public abstract class BaseLocaleConverter implements LocaleConverter { private Object defaultValue; /** Should we return the default value on conversion errors? */ - protected boolean useDefault = false; + protected boolean useDefault; /** The locale specified to our Constructor, by default - system locale. */ protected Locale locale = Locale.getDefault(); @@ -85,7 +85,7 @@ public abstract class BaseLocaleConverter implements LocaleConverter { /** The flag indicating whether the given pattern string is localized or not. */ - protected boolean locPattern = false; + protected boolean locPattern; /** * Create a {@link LocaleConverter} that will throw a {@link ConversionException} diff --git a/src/main/java/org/apache/commons/beanutils/locale/LocaleConvertUtilsBean.java b/src/main/java/org/apache/commons/beanutils/locale/LocaleConvertUtilsBean.java index d02064e2..d02f0f4d 100644 --- a/src/main/java/org/apache/commons/beanutils/locale/LocaleConvertUtilsBean.java +++ b/src/main/java/org/apache/commons/beanutils/locale/LocaleConvertUtilsBean.java @@ -182,7 +182,7 @@ public class LocaleConvertUtilsBean { private Locale defaultLocale = Locale.getDefault(); /** Indicate whether the pattern is localized or not */ - private boolean applyLocalized = false; + private boolean applyLocalized; /** The <code>Log</code> instance for this class. */ private final Log log = LogFactory.getLog(LocaleConvertUtils.class); diff --git a/src/test/java/org/apache/commons/beanutils/NestedTestBean.java b/src/test/java/org/apache/commons/beanutils/NestedTestBean.java index c5c85f8c..79d66eb7 100644 --- a/src/test/java/org/apache/commons/beanutils/NestedTestBean.java +++ b/src/test/java/org/apache/commons/beanutils/NestedTestBean.java @@ -34,7 +34,7 @@ public class NestedTestBean { private String testString = "NOT SET"; - private boolean testBoolean = false; + private boolean testBoolean; private NestedTestBean indexedBeans[]; diff --git a/src/test/java/org/apache/commons/beanutils/TestBean.java b/src/test/java/org/apache/commons/beanutils/TestBean.java index e64d1a19..ccd080e5 100644 --- a/src/test/java/org/apache/commons/beanutils/TestBean.java +++ b/src/test/java/org/apache/commons/beanutils/TestBean.java @@ -244,7 +244,7 @@ private java.util.Date dateProperty; * rules described in the JavaBeans Specification, this will be considered * a read-only boolean property, using isInvalidBoolean() as the getter.</p> */ - private boolean invalidBoolean = false; + private boolean invalidBoolean; public TestBean() { listIndexed.add("String 0");
