This is an automated email from the ASF dual-hosted git repository. ggregory pushed a commit to branch 1.X in repository https://gitbox.apache.org/repos/asf/commons-beanutils.git
commit 4386e192f2faa68d3b40ea53a9a4cd95fcff3c4c Author: Gary D. Gregory <[email protected]> AuthorDate: Wed Dec 25 18:30:28 2024 -0500 Don't initialize instance variables to their default values --- src/main/java/org/apache/commons/beanutils/BeanComparator.java | 4 ++-- src/main/java/org/apache/commons/beanutils/BeanUtils.java | 2 +- src/main/java/org/apache/commons/beanutils/ConversionException.java | 2 +- src/main/java/org/apache/commons/beanutils/DynaProperty.java | 2 +- src/main/java/org/apache/commons/beanutils/MethodUtils.java | 2 +- src/main/java/org/apache/commons/beanutils/PropertyUtils.java | 2 +- src/main/java/org/apache/commons/beanutils/PropertyUtilsBean.java | 4 ++-- .../commons/beanutils/locale/converters/DateLocaleConverter.java | 2 +- src/test/java/org/apache/commons/beanutils/A.java | 2 +- src/test/java/org/apache/commons/beanutils/BeanificationTestCase.java | 2 +- src/test/java/org/apache/commons/beanutils/TestResultSet.java | 2 +- .../apache/commons/beanutils/locale/LocaleBeanificationTestCase.java | 2 +- 12 files changed, 14 insertions(+), 14 deletions(-) diff --git a/src/main/java/org/apache/commons/beanutils/BeanComparator.java b/src/main/java/org/apache/commons/beanutils/BeanComparator.java index 5531d8ad..9e975fe6 100644 --- a/src/main/java/org/apache/commons/beanutils/BeanComparator.java +++ b/src/main/java/org/apache/commons/beanutils/BeanComparator.java @@ -48,12 +48,12 @@ import org.apache.commons.collections.comparators.ComparableComparator; public class BeanComparator<T> implements Comparator<T>, Serializable { private static final long serialVersionUID = 1L; - + /** * Method name to call to compare. */ private String property; - + /** * BeanComparator will pass the values of the specified bean property to this Comparator. If your bean property is not a comparable or contains null values, * a suitable comparator may be supplied in this constructor. diff --git a/src/main/java/org/apache/commons/beanutils/BeanUtils.java b/src/main/java/org/apache/commons/beanutils/BeanUtils.java index 21cccdd0..c1d4df96 100644 --- a/src/main/java/org/apache/commons/beanutils/BeanUtils.java +++ b/src/main/java/org/apache/commons/beanutils/BeanUtils.java @@ -44,7 +44,7 @@ public class BeanUtils { * this class. */ @Deprecated - private static int debug = 0; + private static int debug; /** * <p>Clone a bean based on the available property getters and setters, diff --git a/src/main/java/org/apache/commons/beanutils/ConversionException.java b/src/main/java/org/apache/commons/beanutils/ConversionException.java index e6d32884..5cc33969 100644 --- a/src/main/java/org/apache/commons/beanutils/ConversionException.java +++ b/src/main/java/org/apache/commons/beanutils/ConversionException.java @@ -33,7 +33,7 @@ public class ConversionException extends RuntimeException { * @deprecated Use {@link Throwable#getCause()}}. */ protected Throwable cause; - + /** * Constructs a new exception with the specified message. * diff --git a/src/main/java/org/apache/commons/beanutils/DynaProperty.java b/src/main/java/org/apache/commons/beanutils/DynaProperty.java index ff819658..2c00eb44 100644 --- a/src/main/java/org/apache/commons/beanutils/DynaProperty.java +++ b/src/main/java/org/apache/commons/beanutils/DynaProperty.java @@ -338,7 +338,7 @@ public class DynaProperty implements Serializable { /** * Writes this object safely. There are issues with serializing primitive class types on certain JVM versions (including java 1.3). This method provides a * workaround. - * + * * @param out Where to write. * @throws IOException if I/O errors occur while writing to the underlying stream. */ diff --git a/src/main/java/org/apache/commons/beanutils/MethodUtils.java b/src/main/java/org/apache/commons/beanutils/MethodUtils.java index e7e13493..fa9ff556 100644 --- a/src/main/java/org/apache/commons/beanutils/MethodUtils.java +++ b/src/main/java/org/apache/commons/beanutils/MethodUtils.java @@ -125,7 +125,7 @@ public class MethodUtils { * really optional we can ignore this problem; only one of the webapps * will get the warning in its logs but that should be good enough. */ - private static boolean loggedAccessibleWarning = false; + private static boolean loggedAccessibleWarning; /** * Indicates whether methods should be cached for improved performance. diff --git a/src/main/java/org/apache/commons/beanutils/PropertyUtils.java b/src/main/java/org/apache/commons/beanutils/PropertyUtils.java index 1a6674b3..609aa42b 100644 --- a/src/main/java/org/apache/commons/beanutils/PropertyUtils.java +++ b/src/main/java/org/apache/commons/beanutils/PropertyUtils.java @@ -112,7 +112,7 @@ public class PropertyUtils { * @deprecated The <code>debug</code> static property is no longer used */ @Deprecated - private static int debug = 0; + private static int debug; /** * Adds a <code>BeanIntrospector</code>. This object is invoked when the diff --git a/src/main/java/org/apache/commons/beanutils/PropertyUtilsBean.java b/src/main/java/org/apache/commons/beanutils/PropertyUtilsBean.java index 4545f833..4b398eb3 100644 --- a/src/main/java/org/apache/commons/beanutils/PropertyUtilsBean.java +++ b/src/main/java/org/apache/commons/beanutils/PropertyUtilsBean.java @@ -136,9 +136,9 @@ public class PropertyUtilsBean { * The cache of PropertyDescriptor arrays for beans we have already * introspected, keyed by the java.lang.Class of this object. */ - private WeakFastHashMap<Class<?>, BeanIntrospectionData> descriptorsCache = null; + private WeakFastHashMap<Class<?>, BeanIntrospectionData> descriptorsCache; - private WeakFastHashMap<Class<?>, FastHashMap> mappedDescriptorsCache = null; + private WeakFastHashMap<Class<?>, FastHashMap> mappedDescriptorsCache; /** Log instance */ diff --git a/src/main/java/org/apache/commons/beanutils/locale/converters/DateLocaleConverter.java b/src/main/java/org/apache/commons/beanutils/locale/converters/DateLocaleConverter.java index d8c6a0af..aba00a37 100644 --- a/src/main/java/org/apache/commons/beanutils/locale/converters/DateLocaleConverter.java +++ b/src/main/java/org/apache/commons/beanutils/locale/converters/DateLocaleConverter.java @@ -66,7 +66,7 @@ public class DateLocaleConverter extends BaseLocaleConverter { /** Should the date conversion be lenient? */ - boolean isLenient = false; + boolean isLenient; /** * Create a {@link org.apache.commons.beanutils.locale.LocaleConverter} diff --git a/src/test/java/org/apache/commons/beanutils/A.java b/src/test/java/org/apache/commons/beanutils/A.java index b035ab5e..92d6b937 100644 --- a/src/test/java/org/apache/commons/beanutils/A.java +++ b/src/test/java/org/apache/commons/beanutils/A.java @@ -26,7 +26,7 @@ import java.io.OutputStream; */ public class A { - boolean called = false; + boolean called; public void foo(final OutputStream os) { diff --git a/src/test/java/org/apache/commons/beanutils/BeanificationTestCase.java b/src/test/java/org/apache/commons/beanutils/BeanificationTestCase.java index deebda5f..f44a9f69 100644 --- a/src/test/java/org/apache/commons/beanutils/BeanificationTestCase.java +++ b/src/test/java/org/apache/commons/beanutils/BeanificationTestCase.java @@ -40,7 +40,7 @@ public class BeanificationTestCase extends TestCase { class Signal { private Exception e; - private int signal = 0; + private int signal; private BeanUtilsBean bean; private PropertyUtilsBean propertyUtils; private ConvertUtilsBean convertUtils; diff --git a/src/test/java/org/apache/commons/beanutils/TestResultSet.java b/src/test/java/org/apache/commons/beanutils/TestResultSet.java index 32924282..6b7ecf0f 100644 --- a/src/test/java/org/apache/commons/beanutils/TestResultSet.java +++ b/src/test/java/org/apache/commons/beanutils/TestResultSet.java @@ -72,7 +72,7 @@ public class TestResultSet implements InvocationHandler { /** * Current row number (0 means "before the first one"). */ - protected int row = 0; + protected int row; /** * The constant (per run) value used to initialize date/time/timestamp. diff --git a/src/test/java/org/apache/commons/beanutils/locale/LocaleBeanificationTestCase.java b/src/test/java/org/apache/commons/beanutils/locale/LocaleBeanificationTestCase.java index 3522cc41..da547afa 100644 --- a/src/test/java/org/apache/commons/beanutils/locale/LocaleBeanificationTestCase.java +++ b/src/test/java/org/apache/commons/beanutils/locale/LocaleBeanificationTestCase.java @@ -47,7 +47,7 @@ public class LocaleBeanificationTestCase extends TestCase { class Signal { private Exception e; - private int signal = 0; + private int signal; private LocaleBeanUtilsBean bean; private LocaleConvertUtilsBean convertUtils; private Object marker;
