This is an automated email from the ASF dual-hosted git repository. aherbert pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-numbers.git
commit 0569f2394dd4117c8ad9872befc923e0add2f593 Author: Alex Herbert <[email protected]> AuthorDate: Fri Nov 8 20:36:03 2019 +0000 Fixed checkstyle for field. --- .../org/apache/commons/numbers/field/BigFractionField.java | 2 +- .../src/main/java/org/apache/commons/numbers/field/FP64.java | 4 +++- .../main/java/org/apache/commons/numbers/field/FP64Field.java | 6 +++--- .../java/org/apache/commons/numbers/field/FractionField.java | 2 +- .../java/org/apache/commons/numbers/field/FieldTestData.java | 10 ++++------ .../test/java/org/apache/commons/numbers/field/FieldsList.java | 2 -- 6 files changed, 12 insertions(+), 14 deletions(-) diff --git a/commons-numbers-field/src/main/java/org/apache/commons/numbers/field/BigFractionField.java b/commons-numbers-field/src/main/java/org/apache/commons/numbers/field/BigFractionField.java index 79e563f..e46dc43 100644 --- a/commons-numbers-field/src/main/java/org/apache/commons/numbers/field/BigFractionField.java +++ b/commons-numbers-field/src/main/java/org/apache/commons/numbers/field/BigFractionField.java @@ -21,7 +21,7 @@ import org.apache.commons.numbers.fraction.BigFraction; /** * {@link BigFraction} field. */ -public class BigFractionField extends AbstractField<BigFraction> { +public final class BigFractionField extends AbstractField<BigFraction> { /** Singleton. */ private static final BigFractionField INSTANCE = new BigFractionField(); diff --git a/commons-numbers-field/src/main/java/org/apache/commons/numbers/field/FP64.java b/commons-numbers-field/src/main/java/org/apache/commons/numbers/field/FP64.java index 764b51c..50374d4 100644 --- a/commons-numbers-field/src/main/java/org/apache/commons/numbers/field/FP64.java +++ b/commons-numbers-field/src/main/java/org/apache/commons/numbers/field/FP64.java @@ -23,9 +23,11 @@ import org.apache.commons.numbers.core.Precision; * Wraps a {@code double} value in order to be used as a field * element. */ -public class FP64 extends Number +public final class FP64 extends Number implements NativeOperators<FP64>, Comparable<FP64> { + private static final long serialVersionUID = 1L; + /** Additive neutral. */ private static final FP64 ZERO = new FP64(0); /** Multiplicative neutral. */ diff --git a/commons-numbers-field/src/main/java/org/apache/commons/numbers/field/FP64Field.java b/commons-numbers-field/src/main/java/org/apache/commons/numbers/field/FP64Field.java index 8d929af..c853dbd 100644 --- a/commons-numbers-field/src/main/java/org/apache/commons/numbers/field/FP64Field.java +++ b/commons-numbers-field/src/main/java/org/apache/commons/numbers/field/FP64Field.java @@ -19,10 +19,10 @@ package org.apache.commons.numbers.field; /** * {@link Double} field. */ -public class FP64Field extends AbstractField<FP64> { - /** 0d */ +public final class FP64Field extends AbstractField<FP64> { + /** 0d. */ private static final FP64 ZERO = FP64.of(0d); - /** 1d */ + /** 1d. */ private static final FP64 ONE = FP64.of(1d); /** Singleton. */ private static final FP64Field INSTANCE = new FP64Field(); diff --git a/commons-numbers-field/src/main/java/org/apache/commons/numbers/field/FractionField.java b/commons-numbers-field/src/main/java/org/apache/commons/numbers/field/FractionField.java index 0cb9dc8..ba5549c 100644 --- a/commons-numbers-field/src/main/java/org/apache/commons/numbers/field/FractionField.java +++ b/commons-numbers-field/src/main/java/org/apache/commons/numbers/field/FractionField.java @@ -21,7 +21,7 @@ import org.apache.commons.numbers.fraction.Fraction; /** * {@link Fraction} field. */ -public class FractionField extends AbstractField<Fraction> { +public final class FractionField extends AbstractField<Fraction> { /** Singleton. */ private static final FractionField INSTANCE = new FractionField(); diff --git a/commons-numbers-field/src/test/java/org/apache/commons/numbers/field/FieldTestData.java b/commons-numbers-field/src/test/java/org/apache/commons/numbers/field/FieldTestData.java index 0a2b1cd..526e59e 100644 --- a/commons-numbers-field/src/test/java/org/apache/commons/numbers/field/FieldTestData.java +++ b/commons-numbers-field/src/test/java/org/apache/commons/numbers/field/FieldTestData.java @@ -16,8 +16,6 @@ */ package org.apache.commons.numbers.field; -import java.util.Arrays; - /** * Data store for {@link FieldParametricTest}. */ @@ -27,10 +25,10 @@ class FieldTestData<T> { private final T b; private final T c; - public FieldTestData(Field<T> field, - T a, - T b, - T c) { + FieldTestData(Field<T> field, + T a, + T b, + T c) { this.field = field; this.a = a; this.b = b; diff --git a/commons-numbers-field/src/test/java/org/apache/commons/numbers/field/FieldsList.java b/commons-numbers-field/src/test/java/org/apache/commons/numbers/field/FieldsList.java index a6bc264..96687fc 100644 --- a/commons-numbers-field/src/test/java/org/apache/commons/numbers/field/FieldsList.java +++ b/commons-numbers-field/src/test/java/org/apache/commons/numbers/field/FieldsList.java @@ -16,7 +16,6 @@ */ package org.apache.commons.numbers.field; -import java.util.Arrays; import java.util.List; import java.util.ArrayList; import java.util.Collections; @@ -49,7 +48,6 @@ final class FieldsList { FP64.of(-234.5678901)); } catch (Exception e) { - System.err.println("Unexpected exception while creating the list of fields: " + e); e.printStackTrace(System.err); throw new RuntimeException(e); }
