This is an automated email from the ASF dual-hosted git repository. aherbert pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-numbers.git
commit 1e0970991a952b3c490a434db42bfae90f8f838d Author: Alex Herbert <[email protected]> AuthorDate: Fri Nov 8 20:57:00 2019 +0000 Enable checkstyle failOnViolation in parent pom. Removed duplicate configuration for plugin from the build plugin management section. --- pom.xml | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/pom.xml b/pom.xml index 7d676eb..115f5b0 100644 --- a/pom.xml +++ b/pom.xml @@ -240,7 +240,6 @@ <plugin> <groupId>org.apache.maven.plugins</groupId> <artifactId>maven-checkstyle-plugin</artifactId> - <version>${numbers.checkstyle.version}</version> <dependencies> <dependency> <groupId>com.puppycrawl.tools</groupId> @@ -255,8 +254,7 @@ <suppressionsLocation>${numbers.parent.dir}/src/main/resources/checkstyle/checkstyle-suppressions.xml</suppressionsLocation> <enableRulesSummary>false</enableRulesSummary> <logViolationsToConsole>false</logViolationsToConsole> - <!-- TODO: Set to true when Checkstyle has been fixed. --> - <failOnViolation>false</failOnViolation> + <failOnViolation>true</failOnViolation> <resourceExcludes>NOTICE.txt,LICENSE.txt,**/maven-archiver/pom.properties,**/resolver-status.properties</resourceExcludes> <excludes>**/generated/**.java</excludes> </configuration> @@ -355,14 +353,6 @@ <groupId>org.apache.maven.plugins</groupId> <artifactId>maven-checkstyle-plugin</artifactId> <version>${numbers.checkstyle.version}</version> - <configuration> - <includeTestSourceDirectory>false</includeTestSourceDirectory> - <configLocation>${numbers.parent.dir}/src/main/resources/checkstyle/checkstyle.xml</configLocation> - <headerLocation>${numbers.parent.dir}/src/main/resources/checkstyle/license-header.txt</headerLocation> - <logViolationsToConsole>false</logViolationsToConsole> - <failOnViolation>false</failOnViolation> - <resourceExcludes>NOTICE.txt,LICENSE.txt</resourceExcludes> - </configuration> </plugin> </plugins> </pluginManagement>
