This is an automated email from the ASF dual-hosted git repository. ggregory pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-compress.git
commit f5ee439042e309980d62bb3a338db18b87775445 Author: Gary Gregory <[email protected]> AuthorDate: Thu Dec 8 11:04:54 2022 -0500 Convert cascading if/else to switch --- .../apache/commons/compress/harmony/pack200/BHSDCodec.java | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/src/main/java/org/apache/commons/compress/harmony/pack200/BHSDCodec.java b/src/main/java/org/apache/commons/compress/harmony/pack200/BHSDCodec.java index ff1d99bd..c03cf7a6 100644 --- a/src/main/java/org/apache/commons/compress/harmony/pack200/BHSDCodec.java +++ b/src/main/java/org/apache/commons/compress/harmony/pack200/BHSDCodec.java @@ -381,13 +381,17 @@ public final class BHSDCodec extends Codec { final BHSDCodec bh0 = new BHSDCodec(b, h); return bh0.largest(); } - if (s == 0) { + switch (s) { + case 0: result = cardinality() - 1; - } else if (s == 1) { + break; + case 1: result = cardinality() / 2 - 1; - } else if (s == 2) { + break; + case 2: result = (3L * cardinality()) / 4 - 1; - } else { + break; + default: throw new Error("Unknown s value"); } return Math.min((s == 0 ? ((long) Integer.MAX_VALUE) << 1 : Integer.MAX_VALUE) - 1, result);
