This is an automated email from the ASF dual-hosted git repository. ggregory pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-compress.git
commit 37c2c30de9e708fbbf9762ac4817e7d5b18885cc Author: Gary Gregory <[email protected]> AuthorDate: Thu Dec 8 11:10:18 2022 -0500 Convert cascading if/else to switch Make private class static --- .../compress/harmony/unpack200/NewAttributeBands.java | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/src/main/java/org/apache/commons/compress/harmony/unpack200/NewAttributeBands.java b/src/main/java/org/apache/commons/compress/harmony/unpack200/NewAttributeBands.java index 2bcca885..4e68e144 100644 --- a/src/main/java/org/apache/commons/compress/harmony/unpack200/NewAttributeBands.java +++ b/src/main/java/org/apache/commons/compress/harmony/unpack200/NewAttributeBands.java @@ -341,7 +341,7 @@ public class NewAttributeBands extends BandSet { } - private abstract class LayoutElement implements AttributeLayoutElement { + private abstract static class LayoutElement implements AttributeLayoutElement { protected int getLength(final char uint_type) { int length = 0; @@ -407,12 +407,18 @@ public class NewAttributeBands extends BandSet { } else if (tag.startsWith("OS")) { final char uint_type = tag.substring(2).toCharArray()[0]; final int length = getLength(uint_type); - if (length == 1) { + switch (length) { + case 1: value = (byte) value; - } else if (length == 2) { + break; + case 2: value = (short) value; - } else if (length == 4) { + break; + case 4: value = value; + break; + default: + break; } attribute.addBCLength(length, value); } else if (tag.startsWith("O")) {
