raphinesse commented on issue #445: (android) Add unit tests for run and retryPromise URL: https://github.com/apache/cordova-android/pull/445#issuecomment-397916940 Great PR :+1: There is one issue though: the handling of promises in tests. All async tests should return a promise instead of using the done callback. That way, Jasmine automatically handles resolution and rejection of these promises. Right now, failing tests would time out and you wouldn't get to see the error that caused the rejection. Thanks a lot for the contribution!
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
