raphinesse commented on issue #445: (android) Add unit tests for run and retryPromise URL: https://github.com/apache/cordova-android/pull/445#issuecomment-398236038 > I would have looked into replacing retryPromise but I didn't want to be ripping things out in one of my first commits. Understandably so 😅 Given the temporary nature of global spies, please feel free to revert back to using them if you want. My bad for not knowing better. For me, this is good to go. I'd probably squash all commits, but I don't really care either way here. @dpogue what do you say? Thanks again for this great PR and any following ones :+1:
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
