erisu edited a comment on issue #459: CB-14139 android: Add jvmargs flag for custom values URL: https://github.com/apache/cordova-android/pull/459#issuecomment-400962837 @raphinesse I do not mind if the `org.gradle.jvmargs` is defined in the `gradle.properties` file. I also agree that once a new feature is added, it will be hard to remove. [Gradle's Documentation](https://docs.gradle.org/current/userguide/build_environment.html#sec:configuring_jvm_memory) also references the usage of `gradle.properties` for setting the `org.gradle.jvmargs`. The only **potential issue** is for users that have already created their own project's `gradle.properties` file. If the `command-line flag` is removed from `GradleBuilder.js` and `StudioBuilder.js`, users with the `gradle.properties` file may need to manually add the property. Gradle's default to maximum heap size is set to `Xmx1024m` while we had defined ours as `Xmx2048m`. The `command-line flag` setting was committed for [enabling the dex process for large projects](https://github.com/apache/cordova-android/commit/3a33f4c0a62291ed4faf444cd4525952f90a0b57).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
