erisu edited a comment on issue #459: CB-14139 android: Add jvmargs flag for custom values URL: https://github.com/apache/cordova-android/pull/459#issuecomment-402888847 @janpio, sorry for the missing comment. The more I think about it, it's probably better to not add an additional flag to set the jvmargs. It is a quicker and simpler solution but as mentioned, it would be harder to remove the flag in the future. Using the gradle.properties would be better in the long run. Looking back at the potential issue mentioned above when using the properties file, I think we just need to create a GradlePropertiesConfigParser/Writer. If the file doesn't exist, we can either - Create the file with our defaults - Continue using the inline command If the file already exists, parse the file to see if they have the default variables (excluding its value). If the default arguments are missing: - Edit the file with our defaults - Continue using the inline command If they already have the arguments define, then just accept their values. Also, I feel the amount of 32bit users could probably be very low and this would be an edge case. Since the user had a temporary workaround, we might be able to focus on removing all of the command-line usage in-favor of the gradle.properties instead of just jvmargs. The user's temporary workaround did mention setting the environment variables but affecting the whole system. Though testing is needed, it might be possible to set the variable during execution which shouldn't affect the whole system. `_JAVA_OPTIONS=-Xmx512m cordova ...`. The only question is if the set variable is still set when gradle runs.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
