brodybits commented on a change in pull request #624: Add missing log to Java
version check
URL: https://github.com/apache/cordova-android/pull/624#discussion_r248813548
##########
File path: bin/templates/cordova/lib/check_reqs.js
##########
@@ -355,16 +355,16 @@ module.exports.check_android_target = function
(originalError) {
// Returns a promise.
module.exports.run = function () {
return Q.all([this.check_java(), this.check_android()]).then(function
(values) {
- console.log('ANDROID_HOME=' + process.env['ANDROID_HOME']);
Review comment:
I don't think we should get rid of this log statement. This is information
that can help a developer in case something goes wrong.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
