brodybits commented on a change in pull request #624: Add missing log to Java
version check
URL: https://github.com/apache/cordova-android/pull/624#discussion_r248821295
##########
File path: bin/templates/cordova/lib/check_reqs.js
##########
@@ -355,16 +355,16 @@ module.exports.check_android_target = function
(originalError) {
// Returns a promise.
module.exports.run = function () {
return Q.all([this.check_java(), this.check_android()]).then(function
(values) {
- console.log('ANDROID_HOME=' + process.env['ANDROID_HOME']);
- console.log('JAVA_HOME=' + process.env['JAVA_HOME']);
Review comment:
Another thing is that `check_reqs.js` will actually set
`process.env['JAVA_HOME']` if necessary to keep track of the actual Java JDK
location. I think we should fix `check_reqs.js` to track this information in an
internal variable instead. I would favor working on this in a separate PR, with
some more leisure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
