breautek commented on issue #781: [MAJOR] Migrate from shelljs to fs-extra
URL: https://github.com/apache/cordova-android/issues/781#issuecomment-534337345
 
 
   ```js
   // checks if file exists and then deletes. Error if doesn't exist
   function removeFile (project_dir, src) {
       var file = path.resolve(project_dir, src);
       shell.rm('-Rf', file);
   }
   
   // deletes file/directory without checking
   function removeFileF (file) {
       shell.rm('-Rf', file);
   }
   ```
   @brodybits 
   
   Do you think these two functions could be merged into one? They both appear 
to be doing essentially the same thing, and I believe the comments are also 
out-dated... as `removeFile` doesn't do anything special about checking for 
existence, and if it does throw an error, so would `removeFileF`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to