breautek commented on issue #781: [MAJOR] Migrate from shelljs to fs-extra URL: https://github.com/apache/cordova-android/issues/781#issuecomment-534370457 https://github.com/apache/cordova-android/blob/c35a990c09f1ab278873754eb7f81e52250893a3/bin/lib/create.js#L75-L95 These snippet of contains a lot of shell usages, and where it uses `ls` I've replaced the implementation using `readdirsSync` where necessary, but in this instance I think this is legacy code that can simply be removed. The code appears to be looking for old jar files that must of existed 6+ years ago but is no longer required. The commit that adds this check & jar removal can be found [here](https://github.com/apache/cordova-android/commit/7c446b222d0c66dd9d2a23ef695a09d42669a9d3). It is referencing a JIRA id that doesn't appear to exist anymore. I think anybody today won't have these old jar files to begin with.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
