raphinesse commented on a change in pull request #763: refactor: replace
superspawn & child_process with execa
URL: https://github.com/apache/cordova-ios/pull/763#discussion_r364466859
##########
File path: bin/templates/scripts/cordova/lib/Podfile.js
##########
@@ -391,25 +389,14 @@ Podfile.prototype.install = function
(requirementsCheckerFunction) {
return requirementsCheckerFunction()
.then(toolOptions => this.before_install(toolOptions))
.then(toolOptions => {
- if (toolOptions.ignore) {
- events.emit('verbose', '==== pod install start ====\n');
- events.emit('verbose', toolOptions.ignoreMessage);
- return Q.resolve();
- } else {
- return superspawn.spawn('pod', ['install', '--verbose'], opts)
- .progress(stdio => {
- if (stdio.stderr) { console.error(stdio.stderr); }
- if (stdio.stdout) {
- if (first) {
- events.emit('verbose', '==== pod install start
====\n');
- first = false;
- }
- events.emit('verbose', stdio.stdout);
- }
- });
- }
+ events.emit('verbose', '==== pod install start ====\n');
+
+ return toolOptions.ignore
+ ? Q.resolve(toolOptions.ignoreMessage)
Review comment:
For consistency we should remove non-Q in both cases I guess
```suggestion
? Promise.resolve(toolOptions.ignoreMessage)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
