raphinesse commented on a change in pull request #763: refactor: replace
superspawn & child_process with execa
URL: https://github.com/apache/cordova-ios/pull/763#discussion_r364470458
##########
File path: bin/update
##########
@@ -34,4 +34,4 @@ if (args.help || args.argv.remain.length === 0) {
require('./templates/scripts/cordova/loggingHelper').adjustLoggerLevel(args);
-Api.updatePlatform(args.argv.remain[0], { link: (args.link || args.shared)
}).done();
+Api.updatePlatform(args.argv.remain[0], { link: (args.link || args.shared) });
Review comment:
On error, the old code causes an uncaught exception, the new one an
unhandled rejection.
I would suggest to fix the code, maybe even in a preceding PR. Adding this
should suffice and would be in line with the other binaries in this repo:
```js
.catch(err => {
console.log(err);
process.exit(2);
});
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
