erisu edited a comment on issue #438: Add support for EnableGoogleServicesPlugin URL: https://github.com/apache/cordova-android/pull/438#issuecomment-573939558 @chemerisuk I would like to try and get this PR updated and merged before the upcoming major release. If possible, could you rebase the PR with master and fix the conflicting files? Also, as I proposed in a previous comment, could you wrap the `classpath 'com.google.gms:google-services:3.2.1'` with the `EnableGoogleServicesPlugin`? The code snippet that I provided in a previous comment will work as intended. You will need to add the `apply from: '../CordovaLib/cordova.gradle'` to the `dependencies` scope to have access to the helper methods. I had tested this locally and it should not cause any problems. Lastly, since this PR was created awhile back, I had some other nice to have that could be applied with this PR, if you can do this, it will be great. If you do not have the time, I can do it in a second PR if needed. 1. Bump the Google Services version to a newer version. I recall that the `phonegap-plugin-push` plugin had build issues with `4.2.0` so maybe bump the version to `4.1.0` which people reported to work. Actually, with this PR and the `phonegap-plugin-push` plugin, there is a build issue which will need investigation and I am suspecting it might be related that the `phonegap-plugin-push` plugin dependency on `cordova-support-google-services`. 2. Could we introduce a second preference config options: `GoogleServicesPluginVersion` which would allow users the ability to decide what version they would want to use. (Default to `4.1.0`). Please let me know if you able to do this or if I should create a new PR based from your changes and apply the additional changes.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
