erisu edited a comment on issue #438: Add support for EnableGoogleServicesPlugin URL: https://github.com/apache/cordova-android/pull/438#issuecomment-574946339 @chemerisuk I do not have an issue ticket regarding the issues I described with the `phonegap-plugin-push` plugin. But, I pushed a PR that briefly explains changes to the plugin that will be needed to use these new preference options without having a build issue. It removed the enable google services plugin dependency. The issue the plugin had was a conflict with the new preferences enabling the Google Services in the buildscript while the enable google services plugin dependency did the same thing. Here is the PR: https://github.com/phonegap/phonegap-plugin-push/pull/2873 It is currently labeled as `DRAFT` because we will need to first release the major.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
