erisu commented on a change in pull request #765: Fix error parsing
plist_file_entry when adding extension in xcode
URL: https://github.com/apache/cordova-ios/pull/765#discussion_r367777612
##########
File path: bin/templates/scripts/cordova/lib/projectFile.js
##########
@@ -40,8 +40,18 @@ function parseProjectFile (locations) {
const xcodeproj = xcode.project(pbxPath);
xcodeproj.parseSync();
- const xcBuildConfiguration = xcodeproj.pbxXCBuildConfigurationSection();
- const plist_file_entry = _.find(xcBuildConfiguration, entry =>
entry.buildSettings && entry.buildSettings.INFOPLIST_FILE);
+ var projectName = '';
+ if (fs.readdirSync(project_dir).find(d => d.includes('.xcworkspace'))) {
+ projectName = fs.readdirSync(project_dir).find(d =>
d.includes('.xcworkspace')).replace('.xcworkspace', '');
+ }
+ var xcBuildConfiguration = xcodeproj.pbxXCBuildConfigurationSection();
+ var plist_file_entry = _.find(xcBuildConfiguration, function (entry) {
+ return (
+ entry.buildSettings &&
+ entry.buildSettings.INFOPLIST_FILE &&
+ projectName ?
entry.buildSettings.INFOPLIST_FILE.includes(projectName) : true
+ );
+ });
const plist_file = path.join(project_dir,
plist_file_entry.buildSettings.INFOPLIST_FILE.replace(/^"(.*)"$/g,
'$1').replace(/\\&/g, '&'));
Review comment:
Update: Here are some more sample `INFOPLIST_FILE` values. On the blank
project I added some random watch extensions to create more data.
```
"MyAppWatchExtension Extension/Info.plist"
```
```
"SomeOtherWatchExtension WatchKit Extension/Info.plist"
```
```
"SomeOtherWatchExtension WatchKit App/Info.plist"
```
Not sure why this one didn't have double quotation wrapper like there is
also cases where its not wrapped.
```
MyAppWatchExtension/Info.plist
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
