sou2 commented on a change in pull request #765: Fix error parsing
plist_file_entry when adding extension in xcode
URL: https://github.com/apache/cordova-ios/pull/765#discussion_r379340409
##########
File path: bin/templates/scripts/cordova/lib/projectFile.js
##########
@@ -40,8 +40,19 @@ function parseProjectFile (locations) {
const xcodeproj = xcode.project(pbxPath);
xcodeproj.parseSync();
+ let projectName = '';
+ const workspaceCollection = fs.readdirSync(project_dir).find(d =>
d.includes('.xcworkspace'));
+ if (workspaceCollection) {
+ projectName = fs.readdirSync(project_dir).find(d =>
d.includes('.xcworkspace')).replace('.xcworkspace', '');
+ }
const xcBuildConfiguration = xcodeproj.pbxXCBuildConfigurationSection();
- const plist_file_entry = _.find(xcBuildConfiguration, entry =>
entry.buildSettings && entry.buildSettings.INFOPLIST_FILE);
+ const plist_file_entry = _.find(xcBuildConfiguration, function (entry) {
+ return (
+ entry.buildSettings &&
+ entry.buildSettings.INFOPLIST_FILE &&
+ projectName ?
entry.buildSettings.INFOPLIST_FILE.includes(`${projectName}/${projectName}-Info.plist`)
: true
Review comment:
The ternary operator (`? :`) needs to be enclosed in parenthesis. It has
lower priority than the `&&` operator. Else, it crashes on my app because it
returns true for an entry that has no `buildSettings`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
