erisu commented on a change in pull request #88: Fix for issues with 'cordova
run' command.
URL: https://github.com/apache/cordova-browser/pull/88#discussion_r369321692
##########
File path: bin/template/cordova/lib/run.js
##########
@@ -26,9 +26,9 @@ var cordovaServe = require('cordova-serve');
module.exports.run = function (args) {
// defaults
- args.port = args.port || 8000;
- args.target = args.target || 'default'; // make default the system browser
- args.noLogOutput = args.silent || false;
+ var port = args.port || 8000;
+ var target = args.target || 'default'; // make default the system browser
+ var noLogOutput = args.silent || false;
Review comment:
These can be deleted if you include the changes above. This also includes
the comment and new line.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
