erisu commented on a change in pull request #88: Fix for issues with 'cordova 
run' command.
URL: https://github.com/apache/cordova-browser/pull/88#discussion_r369321914
 
 

 ##########
 File path: bin/template/cordova/lib/run.js
 ##########
 @@ -57,7 +57,7 @@ module.exports.run = function (args) {
 
             console.log('startPage = ' + startPage);
             console.log('Static file server running @ ' + projectUrl + '\nCTRL 
+ C to shut down');
-            return server.launchBrowser({ 'target': args.target, 'url': 
projectUrl });
+            return server.launchBrowser({ 'target': target, 'url': projectUrl 
});
 
 Review comment:
   ```suggestion
               return server.launchBrowser({ target, url: projectUrl });
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to