dpogue commented on a change in pull request #773: refactor: drop uiwebview & add wkwebview URL: https://github.com/apache/cordova-ios/pull/773#discussion_r372443527
########## File path: CordovaLib/Classes/Private/Plugins/CDVLocalStorage/CDVLocalStorage.m ########## @@ -23,19 +23,12 @@ Licensed to the Apache Software Foundation (ASF) under one @interface CDVLocalStorage () @property (nonatomic, readwrite, strong) NSMutableArray* backupInfo; // array of CDVBackupInfo objects -#if !WK_WEB_VIEW_ONLY -@property (nonatomic, readwrite, weak) id <UIWebViewDelegate> webviewDelegate; -#endif @end @implementation CDVLocalStorage Review comment: I'm pretty sure that all the paths in this file for LocalStorage are UIWebView-specific. Worth a bit more investigation to be sure, but maybe this can be removed entirely. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
