erisu commented on a change in pull request #773: refactor: drop uiwebview & add wkwebview URL: https://github.com/apache/cordova-ios/pull/773#discussion_r376147466
########## File path: CordovaLib/Classes/Private/Plugins/CDVIntentAndNavigationFilter/CDVIntentAndNavigationFilter.h ########## @@ -20,11 +20,7 @@ #import <Cordova/CDVPlugin.h> #import <Cordova/CDVWhitelist.h> -#if WK_WEB_VIEW_ONLY #define CDVWebViewNavigationType int Review comment: `CDVWebViewNavigationType` is used here. https://github.com/erisu/cordova-ios/blob/refactor/swap-webviews/CordovaLib/Classes/Private/Plugins/CDVIntentAndNavigationFilter/CDVIntentAndNavigationFilter.m#L105-L132 https://github.com/erisu/cordova-ios/blob/refactor/swap-webviews/CordovaLib/Classes/Private/Plugins/CDVIntentAndNavigationFilter/CDVIntentAndNavigationFilter.m#L134-L137 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
