erisu commented on a change in pull request #915: Bump minSdkVersion to 22 and
drop pre-Lollipop specific code
URL: https://github.com/apache/cordova-android/pull/915#discussion_r375615955
##########
File path: bin/templates/project/legacy/build.gradle
##########
@@ -223,22 +223,6 @@ android {
}
}
}
- /*
-
- ELSE NOTHING! DON'T MESS WITH THE VERSION CODE IF YOU DON'T HAVE TO!
-
- else if (!cdvVersionCode) {
- def minSdkVersion = cdvMinSdkVersion ?:
privateHelpers.extractIntFromManifest("minSdkVersion")
- // Vary versionCode by the two most common API levels:
- // 14 is ICS, which is the lowest API level for many apps.
- // 20 is Lollipop, which is the lowest API level for the updatable
system webview.
- if (minSdkVersion >= 20) {
- defaultConfig.versionCode += 9
Review comment:
@dpogue Can you confirm if this is safe to remove?
I feel like this may affect the multiple apk build. That part of the code
also reads from the `defaultConfig.versionCode`
I am thinking this should be at least
```
else if (!cdvVersionCode) {
defaultConfig.versionCode += 9
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
