brodybits commented on a change in pull request #915: Bump minSdkVersion to 22
and drop pre-Lollipop specific code
URL: https://github.com/apache/cordova-android/pull/915#discussion_r391959848
##########
File path: framework/src/org/apache/cordova/engine/SystemWebChromeClient.java
##########
@@ -155,7 +155,7 @@ public boolean onConsoleMessage(ConsoleMessage
consoleMessage)
{
if (consoleMessage.message() != null)
LOG.d(LOG_TAG, "%s: Line %d : %s" , consoleMessage.sourceId() ,
consoleMessage.lineNumber(), consoleMessage.message());
- return super.onConsoleMessage(consoleMessage);
+ return super.onConsoleMessage(consoleMessage);
Review comment:
This looks like a form of cleanup that I wish would be more clear in the
description and in the commit message(s). Just a message like "other minor
cleanup" would be awesome. +1 (+100) for making this kind of cleanup!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
