knight9999 commented on a change in pull request #773: refactor: drop uiwebview
& add wkwebview
URL: https://github.com/apache/cordova-ios/pull/773#discussion_r376224897
##########
File path: bin/templates/scripts/cordova/lib/prepare.js
##########
@@ -310,22 +308,6 @@ function handleBuildSettings (platformConfig, locations,
infoPlist) {
events.emit('verbose', `Set SwiftVersion to "${swiftVersion}".`);
project.xcode.updateBuildProperty('SWIFT_VERSION', swiftVersion);
}
- if (wkWebViewOnly) {
- let wkwebviewValue = '1';
- if (wkWebViewOnly === 'true') {
- events.emit('verbose', 'Set WK_WEB_VIEW_ONLY.');
- } else {
- wkwebviewValue = '0';
- events.emit('verbose', 'Unset WK_WEB_VIEW_ONLY.');
- }
- project.xcode.updateBuildProperty('WK_WEB_VIEW_ONLY', wkwebviewValue);
Review comment:
This `WK_WEB_VIEW_ONLY` compile flag (line 321) is used in users' project
xcodeproj (Not in CordovaLib's xcodeproj).
The `WK_WEB_VIEW_ONLY` flag in users' xcodeproj is used in some plugins
(like `cordova-plugin-inappbowser` where `WK_WEB_VIEW_ONLY` flag is used to
check to remove `UIWebView` code). For the backward compatibility, I feel it
is better to keep this `WK_WEB_VIEW_ONLY` flag in users' project for the moment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
