sithwarrior opened a new pull request #189: Variable for Require GPS Hardware URL: https://github.com/apache/cordova-plugin-geolocation/pull/189 ### Platforms affected Android ### Motivation and Context Currently installing this plugin, has the sideeffect of your App only beeing installable on Android devices with GPS hardware. We have clients with tablets without GPS hardware. closes #187 ### Description Added the variable **GPS_REQUIRED** so when installing the pluging, its optional if you want to require GPS Hardware on Android devices. Currently an app with this plugin, cannot run on devices without GPS Hardware, because of this setting in the plugin.xml `<uses-feature android:name="android.hardware.location.gps" />` Also added a description in the readme, under Android Quirks, as this only affects Android atm. Naming of the variable is all caps, as is standard with install time variables, for editing the AndroidManifest.xml. This PR is trying to finish the work in #171 ### Testing Testing installing the plugin with and without the variable, and checked the resulting androidmanifest.xml and tested the resulting apk's. ### Checklist - [ ] I've run the tests to see all new and existing tests pass - [ ] I added automated test coverage as appropriate for this change - [] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`) - [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/)) - [x] I've updated the documentation if necessary
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
