sithwarrior commented on issue #189: Variable for Require GPS Hardware URL: https://github.com/apache/cordova-plugin-geolocation/pull/189#issuecomment-597333787 > Those aren't apache's codebases. I'm talking about consistency within the apache's repositories. Third-party plugins may choose whatever format they like to use. If you look at any other [apache cordova plugin](https://github.com/apache?q=cordova-plugin&type=&language=), you will see preference names defined in `PascalCase` format. @breautek Thats not the case for variables set at install time, that set native build settings, as mentioned earlier. Here from the cordova docs [https://cordova.apache.org/docs/en/latest/plugin_ref/spec.html](url) API_KEY `plugman --platform android --project /path/to/project --plugin name|git-url|path --variable API_KEY=!@CFATGWE%^WGSFDGSDFW$%^#$%YTHGsdfhsfhyer56734 ` Here from the apache cordova camera app `<preference name="ANDROID_SUPPORT_V4_VERSION" default="27.+"/>` Here from the apache cordova media app `<preference name="KEEP_AVAUDIOSESSION_ALWAYS_ACTIVE" default="NO" />` Also it dosent work with `PascalCase` . If you install a plugin with --variable switch, which we need here, it automaticly becomes `UPPER_CASE` when saved in config.xml, and then crashes on build, because it dosent match the `PascalCase` in the plugin.xml
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
