PDLMobileApps opened a new pull request #634: (android) Added option to turn on/off fullscreen mode in Android URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/634 <!-- Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines: http://cordova.apache.org/contribute/contribute_guidelines.html Thanks! --> ### Platforms affected Android ### Motivation and Context <!-- Why is this change required? What problem does it solve? --> Resolves #598 <!-- If it fixes an open issue, please link to the issue here. --> Link to the issue: https://github.com/apache/cordova-plugin-inappbrowser/issues/598 ### Description <!-- Describe your changes in detail --> This PR adds a new Android option to fix bug #598 The new option (fullscreen - yes/no) enables/disables the fullscreen WebView on Android. The default value is no. ### Testing <!-- Please describe in detail how you tested your changes. --> Testing was done manually as I am not sure on how to automate it. 1. Created a new Cordova test app using cordova-plugin-inappbrowser. 2. Executed: `cordova.InAppBrowser.open(url, "_blank", "");` and verified the WebView is not opening in fullscreen mode. 3. Executed: `cordova.InAppBrowser.open(url, "_blank", "fullscreen=no");` and verified the WebView is not opening in fullscreen mode. 4. Executed: `cordova.InAppBrowser.open(url, "_blank", "fullscreen=yes");` and verified the WebView is opening in fullscreen mode. ### Checklist - [x] I've run the tests to see all new and existing tests pass - [ ] I added automated test coverage as appropriate for this change - [x] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`) - [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/)) - [x] I've updated the documentation if necessary
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
