breautek commented on a change in pull request #634: (android) Added option to
turn on/off fullscreen mode in Android
URL:
https://github.com/apache/cordova-plugin-inappbrowser/pull/634#discussion_r393941052
##########
File path: src/android/InAppBrowser.java
##########
@@ -147,6 +148,7 @@ Licensed to the Apache Software Foundation (ASF) under one
private boolean showFooter = false;
private String footerColor = "";
private String beforeload = "";
+ private boolean fullscreen = false;
Review comment:
Not very knowledgeable with the in-app-browser but unless if there is a very
good reason why it should be hard-coded (which I don't think there is any?), I
think we should be non-opinionated and let it be configurable.
Normally I'd also vote to revert the default as well, but if it's been live
for nearly two years, I think it's smarter to just leave the "default" as
`true`. I think if we change it to `false` now, then we would have to treat
this PR as a breaking change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
