breautek commented on issue #189: Variable for Require GPS Hardware URL: https://github.com/apache/cordova-plugin-geolocation/pull/189#issuecomment-600617365 > Besides the small README suggestion, LGTM! > I've done a quick test, the AndroidManifest file is changed as expected. > > Unfortunately, my android devices all have GPS, so I can't really test this besides building the APK. This was the extent to my testing. And I'm not entirely sure if the phone will let you install an APK even if you lack required features or not. This may also just be a google play store where the listing is simply hidden. So once the README has been updated as per your suggestion I'll merge this PR.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
