Hexiaoqiao commented on PR #478: URL: https://github.com/apache/curator/pull/478#issuecomment-1704541547
@kezhuw Great response. Some concerns here. > * Rewrites sequence number as 64-bit integer. I am not sure what the consequence of this. But 32-bit in your case will overflow finally. It could overflowed already hiding by overflow of `Stat.version`. > * Uses a sensible default batch size and refuse small batch size. This is easy in your case, but you will get negative sequence number cause of above. Actually sequence number can be compatible with 32-bit integer overflow, which only should be distinguishable number without other conditions. IMO it is OK even if overflow, actually I try to test it on our test env and it works fine. So it is not hiding issue here. Another side, I totally agree that set the default configuration `ZK_DTSM_TOKEN_SEQNUM_BATCH_SIZE_DEFAULT` to some bigger number (such as 10 or much more) could bypass this issue, however it does not solve root cause about Curator. Right? Thanks again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
