kezhuw commented on PR #478: URL: https://github.com/apache/curator/pull/478#issuecomment-1704716440
> IMO it is OK even if overflow, actually I try to test it on our test env and it works fine. So it is not hiding issue here. @Hexiaoqiao Glad to hear, that is good! > however it does not solve root cause about Curator. Right? I am open to a workaround as long as it fit. For a workaround to work, I think we should guarantee: 1. The promise about "up-to-date" should be guaranteed. 2. The promise about "Changes the shared value only if its value has not changed since the version specified by newValue" should be hold. This means we have to throw exception if `previous.getVersion()` equals to `-1` in call chain of `trySetCount`. I feel hopeless about viable workaround, but not against one. Anyway please go ahead, I would be happy to hear good news. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
