HoustonPutman commented on PR #512:
URL: https://github.com/apache/curator/pull/512#issuecomment-2575985398

   > +1 to global compression
   > 
   > > When using this flag with a custom CompressionProvider, this can easily 
allow for a filtered compression implementation.
   > 
   > I saw no per-operation way to opt out compression if it is enabled global 
while we have method to turn it on if it is not enabled globally. People will 
have to override `CompressionProvider` which complicate things.
   > 
   > I checked `CreateBuilder`, `SetDataBuilder`, `AsyncCreateBuilder`, 
`AsyncSetDataBuilder` and `GetDataBuilder`.
   
   So I've gone ahead and added negative methods for both `Compressible` and 
`Decompressible`. I need to add tests for everything, but the Async APIs should 
be fully covered now too. Lots of ways to do everything, so lots of things to 
test here to make sure nothing got missed....
   
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@curator.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to