HoustonPutman commented on code in PR #512:
URL: https://github.com/apache/curator/pull/512#discussion_r1907442104
##########
curator-x-async/src/main/java/org/apache/curator/x/async/api/AsyncTransactionCreateBuilder.java:
##########
@@ -74,7 +82,7 @@ public interface AsyncTransactionCreateBuilder extends
AsyncPathAndBytesable<Cur
* @see #compressed()
* @return this
*/
- AsyncPathAndBytesable<CuratorOp> withOptions(CreateMode createMode,
List<ACL> aclList, boolean compressed);
+ AsyncPathAndBytesable<CuratorOp> withOptions(CreateMode createMode,
List<ACL> aclList, Boolean compressed);
Review Comment:
> I am thinking it might be more composable for `AsyncXzyBuilder` to return
itself for methods `withAbc`. But it is not binary compatible.
Yes, I absolutely wanted to do that, but thought it would create back-compat
concerns...
I do like your suggestion about the new method that we could then compress
or uncompressed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@curator.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
