stevedlawrence commented on a change in pull request #326: Daffodil 2280
cleanup - removes backpointers and factory patterns no longer needed
URL: https://github.com/apache/incubator-daffodil/pull/326#discussion_r393646395
##########
File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/GroupDef.scala
##########
@@ -22,29 +22,17 @@ import org.apache.daffodil.exceptions.Assert
import scala.xml.Text
import scala.xml.Comment
-final class GlobalGroupDefFactory(defXML: Node, schemaDocument: SchemaDocument)
- extends SchemaComponentFactory(defXML, schemaDocument)
- with GlobalNonElementComponentMixin {
+object GlobalGroupDef {
- def forGroupRef(refXML: Node, refLexicalParent: SchemaComponent, position:
Int,
- isHidden: Boolean): (GroupRef, GlobalGroupDef) = {
+ def apply(defXML: Node, schemaDocument: SchemaDocument) = {
Review comment:
Note that this changes some isHidden logic. I suspect there might be some
conflicts with the work Lola is doing right now to change isHidden to be
handled at runtime. Might make sense to merge Lola's changes in after this,
since this is a pretty big change. Rebasing Lola's work will likely be easier.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
