stevedlawrence commented on a change in pull request #326: Daffodil 2280 cleanup - removes backpointers and factory patterns no longer needed URL: https://github.com/apache/incubator-daffodil/pull/326#discussion_r393649777
########## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/GroupRef.scala ########## @@ -86,6 +105,7 @@ final class SequenceGroupRef( private lazy val globalGroupDef = globalGroupDefArg // once only override def isHidden = isHiddenArg + override def isHiddenGroupRef = isHiddenArg Review comment: Presumably with Lola's change, she'll want to remove isHidden but switch to using isHiddenGroupRef? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
