mbeckerle commented on a change in pull request #343: WIP: Daf 2302 ext var
URL: https://github.com/apache/incubator-daffodil/pull/343#discussion_r400540294
##########
File path: daffodil-japi/src/main/scala/org/apache/daffodil/japi/Daffodil.scala
##########
@@ -257,7 +264,7 @@ class Compiler private[japi] () {
* @param tunables a map of key/value pairs, where the key is the tunable
name and the value is the value to set it to
*/
def setTunables(tunables: java.util.AbstractMap[String, String]): Unit = {
- sCompiler.setTunables(tunables.asScala.toMap)
+ sCompiler = sCompiler.withTunables(tunables.asScala.toMap)
Review comment:
It is much too involved for this patch set. Took me another whole day
pulling the other threads of this review. SAPI/JAPI, and the TDMLDFDLProcessor
classes all still have imperative APIs.
They're much safer now, in that if you say, spawn lots of parse calls on
varous threads, and then start calling things like setExternalDFDLVariables
again on the DP object, nothing bad will happen, because those setter calls
displace the state with a new state.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
