stevedlawrence commented on a change in pull request #343: Daffodil 2302 fixes
external variables API difficulties
URL: https://github.com/apache/incubator-daffodil/pull/343#discussion_r400850058
##########
File path:
daffodil-cli/src/it/scala/org/apache/daffodil/saving/TestCLISaveParser.scala
##########
@@ -262,6 +262,10 @@ class TestCLISaveParser {
}
}
+ /**
+ * Note that in Daffodil 2.6.0 behavior of external variables changed. They
are not saved as part of binary
+ * compiling. They are a runtime-thing only.
+ */
Review comment:
Should we add a warning to the CLI so that if the variables option is used
we let he user know that they are being ignored? Or perhaps in the save()
method we detect if the user has set any variables, and if so output a warning?
Not sure if it's possible to easily detect if variables have been set, so
probably not worth the effort if it's a pain.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
