mbeckerle commented on a change in pull request #346: Fix TDML runner losing
external var assignments in middle of a round …
URL: https://github.com/apache/incubator-daffodil/pull/346#discussion_r402001328
##########
File path:
daffodil-tdml-lib/src/main/scala/org/apache/daffodil/tdml/TDMLRunner.scala
##########
@@ -429,6 +429,8 @@ class DFDLTestSuite private[tdml] (
abstract class TestCase(testCaseXML: NodeSeq, val parent: DFDLTestSuite)
extends Logging {
Review comment:
Add comment that TestCase execution is strongly sequential and single-thread
because whenever we create a new processor with new settings we just assign
this var.
I did things this way rather than restructure the code more functionally,
which would have been a lot of churn. So this code still reflects imperative
style code of the API it was using before.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
