mbeckerle commented on a change in pull request #346: Fix TDML runner losing
external var assignments in middle of a round …
URL: https://github.com/apache/incubator-daffodil/pull/346#discussion_r402326997
##########
File path:
daffodil-tdml-lib/src/main/scala/org/apache/daffodil/tdml/TDMLRunner.scala
##########
@@ -804,8 +815,10 @@ case class ParserTestCase(ptc: NodeSeq, parentArg:
DFDLTestSuite)
case (Some(_), None) => {
compileResult.left.foreach { diags => throw TDMLException(diags,
implString) }
compileResult.right.foreach {
- case (_, processor) =>
- runParseExpectSuccess(processor, dataToParse, nBits,
optExpectedWarnings, optExpectedValidationErrors, validationMode, roundTrip,
implString)
+ case (_, proc) => {
+ processor = proc
+ runParseExpectSuccess(dataToParse, nBits, optExpectedWarnings,
optExpectedValidationErrors, validationMode, roundTrip, implString)
+ }
Review comment:
I have been hesitant to turn on auto-formatting on IDEA thusfar. At some
point I may try it. Right now I have to decide to use it manually.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
