stevedlawrence commented on a change in pull request #369:
URL: https://github.com/apache/incubator-daffodil/pull/369#discussion_r416688743



##########
File path: 
daffodil-core/src/main/scala/org/apache/daffodil/grammar/ModelGroupGrammarMixin.scala
##########
@@ -42,7 +42,7 @@ trait ModelGroupGrammarMixin
   private lazy val groupRightFraming = prod("groupRightFraming") { 
TrailingSkipRegion(this) }
 
   final override lazy val termContentBody = prod("termContentBody") {
-    dfdlStatementEvaluations ~ groupLeftFraming ~ 
groupContentWithInitiatorTerminator ~ groupRightFraming
+    dfdlScopeBegin ~ dfdlStatementEvaluations ~ groupLeftFraming ~ 
groupContentWithInitiatorTerminator ~ groupRightFraming ~ dfdlScopeEnd

Review comment:
       Mabye this is the ordering you're talking about is incorrect? Do we need 
to split up dfdlStatementEvaluations into pattern and not pattern here? So the 
issue is on model groups and not elements?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to