jadams-tresys commented on a change in pull request #369:
URL: https://github.com/apache/incubator-daffodil/pull/369#discussion_r416809826
##########
File path:
daffodil-core/src/main/scala/org/apache/daffodil/grammar/ModelGroupGrammarMixin.scala
##########
@@ -42,7 +42,7 @@ trait ModelGroupGrammarMixin
private lazy val groupRightFraming = prod("groupRightFraming") {
TrailingSkipRegion(this) }
final override lazy val termContentBody = prod("termContentBody") {
- dfdlStatementEvaluations ~ groupLeftFraming ~
groupContentWithInitiatorTerminator ~ groupRightFraming
+ dfdlScopeBegin ~ dfdlStatementEvaluations ~ groupLeftFraming ~
groupContentWithInitiatorTerminator ~ groupRightFraming ~ dfdlScopeEnd
Review comment:
Okay, so I've made a change to make this reflect what is described in
the spec and process statements with patterns before newVariableInstance. I
added a test that I think demonstrates this, but I am struggling to think of a
case where an assert or discriminator statement could affect a
newVariableInstance, especially if you can't use a variable to store the
pattern used by the assert/discriminator. I tried to add a test doing that, but
was unsuccessful.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
