stevedlawrence commented on a change in pull request #394:
URL: https://github.com/apache/incubator-daffodil/pull/394#discussion_r453884432
##########
File path:
daffodil-core/src/main/scala/org/apache/daffodil/dsom/SimpleTypes.scala
##########
@@ -53,9 +54,9 @@ trait TypeBase {
trait NonPrimTypeMixin
sealed trait SimpleTypeBase extends TypeBase
- with HasOptRepTypeMixin {
+ with HasOptRepTypeMixin with SimpleTypeView {
- def primType: PrimType
+ override def primType: PrimType
Review comment:
You could probably just use the same trait trick same as the Views (e.g.
trait that's like org.apache.daffodil.dsom.walker.IntegerView which extends
dsom.walker.PrimTypeView) and then the dpath.PrimType objects extend the
appropriate view. Maybe this is excessive though? I'm trying to imagine a clean
API where the user only has access to things in dsom.walker.* There's a lot of
duplication though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
