andrewjc2000 commented on a change in pull request #394: URL: https://github.com/apache/incubator-daffodil/pull/394#discussion_r453889437
########## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/SimpleTypes.scala ########## @@ -53,9 +54,9 @@ trait TypeBase { trait NonPrimTypeMixin sealed trait SimpleTypeBase extends TypeBase - with HasOptRepTypeMixin { + with HasOptRepTypeMixin with SimpleTypeView { - def primType: PrimType + override def primType: PrimType Review comment: You mentioned that `PrimType` is changed frequently - would this list pose an issue because of that? i.e. wouldn't future developers have to go change this list of primitive Views every time `PrimType` is changed? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org