stevedlawrence commented on a change in pull request #394: URL: https://github.com/apache/incubator-daffodil/pull/394#discussion_r454291104
########## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/walker/AbstractDSOMWalker.scala ########## @@ -0,0 +1,163 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.daffodil.dsom.walker + +import org.apache.daffodil.dpath.NodeInfo.PrimType + +trait CommonContextView { + def namespaces: scala.xml.NamespaceBinding +} + +trait TermView extends CommonContextView { + def isArray: Boolean + def isOptional: Boolean + def walkDSOM[T](walker: AbstractDSOMWalker[T]): Unit = { Review comment: Seems reasonable. So it sounds like basically the API becomes all the different Views and their members, plus some new public method to get the RootView. WIth the RootView, the user can traverse the DSOM tree however they want. And then we have the recursive DSOM walker implementation for users that just want to get a bunch of events and not have to worry about how things DSOM is walked. This feel like it makes the API a little larger and could make it difficult to change in the future, but as long as its experimental until it seems stable that's fine with me. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
